Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC for attributes on statements and blocks. #16

Merged
merged 7 commits into from
Jul 15, 2014
Merged

RFC for attributes on statements and blocks. #16

merged 7 commits into from
Jul 15, 2014

Commits on Mar 20, 2014

  1. RFC for attributes on match arms and statements.

    @huonw
    huonw committed Mar 20, 2014
    Configuration menu
    Copy the full SHA
    fed1f9f View commit details
    Browse the repository at this point in the history

Commits on May 17, 2014

  1. Revise after splitting rust-lang#8 for match arm attributes (now land… 

    …ed).
    @huonw
    huonw committed May 17, 2014
    Configuration menu
    Copy the full SHA
    7520d05 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2014

  1. Revisions to include expressions more definitely. 

    `if` is annoying.
    @huonw
    huonw committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    6148795 View commit details
    Browse the repository at this point in the history

  2. An unfortunately placed # broke the formatting.

    @huonw
    huonw committed Jun 27, 2014
    Configuration menu
    Copy the full SHA
    403d222 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2014

  1. Reword a point for clarity.

    @huonw
    huonw committed Jul 8, 2014
    Configuration menu
    Copy the full SHA
    a037604 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2014

  1. Feedback from @pnkfelix's review: 

    - explicitly disallowing attributes on `if`/`else` due to weirdness
- provide alternatives for this
- add a drawbacks section discussing syntactic lock-down and the
  antipattern of `#[cfg]`
- clarify that this RFC is just for parsing attributes, not requiring that
  `#[cfg]` stripping be added in all these new places.
    @huonw
    huonw committed Jul 15, 2014
    Configuration menu
    Copy the full SHA
    0130066 View commit details
    Browse the repository at this point in the history

  2. Finish my 

    sentences.
    @huonw
    huonw committed Jul 15, 2014
    Configuration menu
    Copy the full SHA
    12e924b View commit details
    Browse the repository at this point in the history