Skip to content

Commit

Permalink
Log rustfmt parsing errors as warnings
Browse files Browse the repository at this point in the history
We unconditionally pass an edition parameter to rustfmt, for some crates
this might fail rustfmt so instead of swallowing the error, at least Log
it on a level that is logged by default so users won't be completely
confused about it.
See for context #10209

Closes #10209
  • Loading branch information
Veykril committed Aug 19, 2022
1 parent 49700e4 commit 638755a
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions crates/rust-analyzer/src/handlers.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1766,7 +1766,7 @@ fn run_rustfmt(

let line_index = snap.file_line_index(file_id)?;

let mut rustfmt = match snap.config.rustfmt() {
let mut command = match snap.config.rustfmt() {
RustfmtConfig::Rustfmt { extra_args, enable_range_formatting } => {
let mut cmd = process::Command::new(toolchain::rustfmt());
cmd.args(extra_args);
Expand Down Expand Up @@ -1831,12 +1831,12 @@ fn run_rustfmt(
}
};

let mut rustfmt = rustfmt
let mut rustfmt = command
.stdin(Stdio::piped())
.stdout(Stdio::piped())
.stderr(Stdio::piped())
.spawn()
.context(format!("Failed to spawn {:?}", rustfmt))?;
.context(format!("Failed to spawn {:?}", command))?;

rustfmt.stdin.as_mut().unwrap().write_all(file.as_bytes())?;

Expand All @@ -1855,7 +1855,11 @@ fn run_rustfmt(
// formatting because otherwise an error is surfaced to the user on top of the
// syntax error diagnostics they're already receiving. This is especially jarring
// if they have format on save enabled.
tracing::info!("rustfmt exited with status 1, assuming parse error and ignoring");
tracing::warn!(
?command,
%captured_stderr,
"rustfmt exited with status 1"
);
Ok(None)
}
_ => {
Expand Down

0 comments on commit 638755a

Please sign in to comment.