fix: incorrect file_id used for ranges in outgoing calls #18802

roife · 2024-12-31T06:12:23Z

rust-analyzer/crates/ide/src/call_hierarchy.rs

Lines 16 to 20 in dae1504

    
           #[derive(Debug, Clone)] 
        
           pub struct CallItem { 
        
               pub target: NavigationTarget, 
        
               pub ranges: Vec<FileRange>, 
        
           }

Here target refers to the definition of the fn which is called, while ranges indicates the location of the call site.

For example:

fn f() {
    g(); // ranges[0]
}

// another file
fn g() {} // target

crates/rust-analyzer/src/handlers/request.rs

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 31, 2024

Veykril reviewed Dec 31, 2024

View reviewed changes

crates/rust-analyzer/src/handlers/request.rs Outdated Show resolved Hide resolved

fix: incorrect file_id used for ranges in outgoing calls

a48bfa9

roife force-pushed the fix-18800 branch from dae1504 to a48bfa9 Compare December 31, 2024 12:10

Veykril approved these changes Dec 31, 2024

View reviewed changes

Veykril added this pull request to the merge queue Dec 31, 2024

Merged via the queue into rust-lang:master with commit c86dd17 Dec 31, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: incorrect file_id used for ranges in outgoing calls #18802

fix: incorrect file_id used for ranges in outgoing calls #18802

roife commented Dec 31, 2024 •

edited

Loading

	#[derive(Debug, Clone)]
	pub struct CallItem {
	pub target: NavigationTarget,
	pub ranges: Vec<FileRange>,
	}

fix: incorrect file_id used for ranges in outgoing calls #18802

fix: incorrect file_id used for ranges in outgoing calls #18802

Conversation

roife commented Dec 31, 2024 • edited Loading

roife commented Dec 31, 2024 •

edited

Loading