Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support variable substitution in vscode settings #9626

Closed
Veykril opened this issue Jul 18, 2021 · 2 comments · Fixed by #12215
Closed

Support variable substitution in vscode settings #9626

Veykril opened this issue Jul 18, 2021 · 2 comments · Fixed by #12215
Labels
A-vscode vscode plugin issues S-actionable Someone could pick this issue up and work on it right now

Comments

@Veykril
Copy link
Member

Veykril commented Jul 18, 2021

VSCode settings variables like ${workspaceFolder} don't get substituted by VSCode in extension settings, so when people try to use these in RA settings they will run into unfortunate surprises, see #4616 (comment).

There is an open issue on the VSCode tracker here, microsoft/vscode#2809 (comment), but it doesn't look like this will be solved in the near future.

So it would be good for us to do the substitution ourselves where applicable as to not surprise vscode users. The list of vars we want to support is here https://code.visualstudio.com/docs/editor/variables-reference#_predefined-variables, not necessarily all of them, but those that make the most sense at least, if possible.

@Veykril
Copy link
Member Author

Veykril commented May 27, 2022

I just realized #12215 only implemented this for the server env, not for the entirey of configs.

@Veykril
Copy link
Member Author

Veykril commented Jan 30, 2023

env part tracked in #14053

@Veykril Veykril closed this as completed Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-vscode vscode plugin issues S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants