-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Rewrite add_lifetime_to_type to add_missing_lifetime #21013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Natural-selection1
wants to merge
9
commits into
rust-lang:master
Choose a base branch
from
Natural-selection1:add_lifetime
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rewrite add_lifetime_to_type to add_missing_lifetime #21013
Natural-selection1
wants to merge
9
commits into
rust-lang:master
from
Natural-selection1:add_lifetime
+626
−241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc5f47a to
e95f1b9
Compare
e95f1b9 to
b14c000
Compare
Contributor
Author
|
It should be possible to use |
A4-Tacks
reviewed
Nov 10, 2025
A4-Tacks
suggested changes
Nov 11, 2025
92443b3 to
6aa7edf
Compare
A4-Tacks
approved these changes
Nov 11, 2025
A4-Tacks
approved these changes
Nov 11, 2025
d317ccd to
ee51e11
Compare
ee51e11 to
95888c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generatetoquickfixadd_missing_lifetimeOperation 1: Supplement all existing lifetime declarations in the ADT
Operation 2: Add a lifetime to all references without one and declare it in the ADT (still leave markers for easy renaming)
before:
now.mp4
after:
add_missing_lifetime.mp4