Optimise SmolStr::clone 4-5x speedup inline, 0.5x heap (slow down)
#21017
+13
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an interesting performance trade-off. We can significantly improve inline
SmolStr::cloneperformance at the expense of heap performance if we use#[cold]&#[inline(never)]hints against the latter.This is a better result for users that care most about inline variant performance. If we think that represents most users it may be worth it.
Benchmarks