Skip to content

Conversation

@kjeremy
Copy link
Contributor

@kjeremy kjeremy commented Oct 8, 2020

No description provided.

@lnicola
Copy link
Member

lnicola commented Oct 8, 2020

We only use cfg_if once, I wonder if it's worth having it (other crates bring in the older version).

@kjeremy
Copy link
Contributor Author

kjeremy commented Oct 8, 2020

I'm not sure. Since it's a bump to 1.0 I'm hoping that our other dependencies update quickly (PRs welcome!).

@kjeremy
Copy link
Contributor Author

kjeremy commented Oct 8, 2020

Interesting test failure on bors:

test tests::test_derive_proc_macro_list ... ok
thread panicked while panicking. aborting.
error: test failed, to rerun pass '-p proc_macro_srv --lib'

Caused by:
process didn't exit successfully: /home/runner/work/rust-analyzer/rust-analyzer/target/debug/deps/proc_macro_srv-32fc1aa629146b4f (signal: 4, SIGILL: illegal instruction)

I wonder if this is because rust 1.47 was just released.

@bors
Copy link
Contributor

bors bot commented Oct 8, 2020

🔒 Permission denied

Existing reviewers: click here to make lnicola a reviewer

@kjeremy
Copy link
Contributor Author

kjeremy commented Oct 8, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 8, 2020

@bors bors bot merged commit 636b413 into rust-lang:master Oct 8, 2020
@kjeremy kjeremy deleted the update-deps branch October 8, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants