Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix accidently quadratic syntax rewriter #6805

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Fix accidently quadratic syntax rewriter #6805

merged 1 commit into from
Dec 10, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Dec 10, 2020

bors r+
🤖

@matklad
Fix accidently quadratic syntax rewriter
3d5be5b 
Switching from SyntaxNode to GreenNode is a costly operation (b/c
dereferencing a synax ptr in `with_green` is linear), so we should
avoid that.
@matklad
Copy link
Member Author

matklad commented Dec 10, 2020

cc @Veykril

@matklad matklad mentioned this pull request Dec 10, 2020
Closed
@bors
Copy link
Contributor

bors bot commented Dec 10, 2020

Build succeeded:

@bors bors bot merged commit 0baff25 into rust-lang:master Dec 10, 2020
@matklad matklad deleted the faster branch December 10, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matklad