-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint identity_conversion
name is misleading
#3106
Comments
Maybe just |
I'd rather propose the opposite and change the text to read
I don't see the difference. |
Rename lint `identity_conversion` to `useless_conversion` Lint name `identity_conversion` was misleading, so this PR renames it to `useless_conversion`. As decision has not really came up in the issue comments, this PR will probably need discussion. fixes #3106 changelog: Rename lint `identity_conversion` to `useless_conversion`
Rename lint `identity_conversion` to `useless_conversion` Lint name `identity_conversion` was misleading, so this PR renames it to `useless_conversion`. As decision has not really came up in the issue comments, this PR will probably need discussion. fixes #3106 changelog: Rename lint `identity_conversion` to `useless_conversion`
Rename lint `identity_conversion` to `useless_conversion` Lint name `identity_conversion` was misleading, so this PR renames it to `useless_conversion`. As decision has not really came up in the issue comments, this PR will probably need discussion. fixes #3106 changelog: Rename lint `identity_conversion` to `useless_conversion`
The lint
identity_conversion
has a somewhat misleading name. It feels like it suggests the identity conversion is being actually done somewhere in the code. In reality, however, this lint checks for useless conversion from some type to the very same type. Indeed, the error that is reported by this lint iserror: identical conversion
, which points exactly to the issue in hand.I want to suggest renaming the lint to match the error report.
I.e.
identity_conversion
->identical_conversion
Or, perhaps, to
useless_identity_conversion
(which is admittedly longer name).What is the policy on lint renaming? Is it something that may be done at all? Supported?
Encouraged/discouraged?
The text was updated successfully, but these errors were encountered: