Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite doc_markdown to use pulldown-cmark #1799

Merged
merged 10 commits into from
Jun 17, 2017
Merged

Rewrite doc_markdown to use pulldown-cmark #1799

merged 10 commits into from
Jun 17, 2017

Commits on Jun 17, 2017

  1. Add itertools and pulldown-cmark dependencies

    @mcarton
    mcarton committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    9c9ad3e View commit details
    Browse the repository at this point in the history

  2. Rewrite doc_markdown to use pulldown-cmark

    @mcarton
    mcarton committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    d2ef1b3 View commit details
    Browse the repository at this point in the history

  3. Fix spans in doc_markdown in most cases

    @mcarton
    mcarton committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    aaf9bce View commit details
    Browse the repository at this point in the history

  4. Fix spans in all cases in doc_markdown

    @mcarton
    mcarton committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    349b45b View commit details
    Browse the repository at this point in the history

  5. Log that doc_markdown has been rewritten 

    I hope this will fix most false positives, and maybe some true
negatives, and won't introduce too much new FP.
    @mcarton
    mcarton committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    1a297f0 View commit details
    Browse the repository at this point in the history

  6. Add a new doc_markdown test from issue comments

    @mcarton
    mcarton committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    81b0efa View commit details
    Browse the repository at this point in the history

  7. Ignore mix of {,non-}sugared doc in doc_markdown

    @mcarton
    mcarton committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    9881b15 View commit details
    Browse the repository at this point in the history

  8. Don't use default features for pulldown-cmark

    @mcarton
    mcarton committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    94cf93c View commit details
    Browse the repository at this point in the history

  9. Don't depend explicitly on pulldown-cmark 

    Use the one from `rustc`'s, which avoids "multiple matching crate"
errors.
    @mcarton
    mcarton committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    34a899c View commit details
    Browse the repository at this point in the history

  10. Fix links in change log

    @mcarton
    mcarton committed Jun 17, 2017
    Configuration menu
    Copy the full SHA
    898dafb View commit details
    Browse the repository at this point in the history