Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing build (adding new Hir::Def type ConstParam) #3750

Merged
merged 1 commit into from
Feb 9, 2019
Merged

Fix failing build (adding new Hir::Def type ConstParam) #3750

merged 1 commit into from
Feb 9, 2019

Conversation

@phansch
Copy link
Member

phansch commented Feb 9, 2019

@bors r+ thanks!

@bors
Copy link
Contributor

bors commented Feb 9, 2019

📌 Commit 66f8fa3 has been approved by phansch

@bors
Copy link
Contributor

bors commented Feb 9, 2019

⌛ Testing commit 66f8fa3 with merge 35e2e1b...

@ghost
Copy link

ghost commented Feb 9, 2019

Looks like utils::opt_def_id is identical to Def::opt_def_id. After this is merged we should remove that function completely.

@bors
Copy link
Contributor

bors commented Feb 9, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing 35e2e1b to master...

@bors bors merged commit 66f8fa3 into rust-lang:master Feb 9, 2019
@h-michael h-michael deleted the const-params branch February 9, 2019 04:09
bors added a commit that referenced this pull request Feb 9, 2019
Use Hir::Def opt_def_id

related with: #3750 (comment)

Using `def.opt_def_id` in `opt_def_id` before replacing all all at once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants