Remove allow in option_option lint test
#6303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ebroto (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ebroto
approved these changes
Nov 10, 2020
|
@bors r+ Thanks! |
|
📌 Commit 8242b2f has been approved by |
bors
added a commit
that referenced
this pull request
Nov 10, 2020
Remove `allow` in `option_option` lint test As it is not triggering locally anymore, I propose to remove `#[allow(clippy::option_option)]` from the test. The goal is also to see what happens on CI. closes: #4298 changelog: none
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 8242b2f has been approved by |
ebroto
removed
the
S-waiting-on-review
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is not triggering locally anymore, I propose to remove
#[allow(clippy::option_option)]from the test.The goal is also to see what happens on CI.
closes: #4298
changelog: none