Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Rustup to 1.9.0-nightly (bf5da36f1 2016-04-06) #842

Closed
wants to merge 2 commits into from
Closed

Conversation

mcarton
Copy link
Member

@mcarton mcarton commented Apr 7, 2016

@mcarton mcarton force-pushed the rustup branch 2 times, most recently from e234961 to 5d276e5 Compare April 7, 2016 16:33
@@ -56,7 +56,7 @@ pub const RANGE_TO_PATH: [&'static str; 3] = ["std", "ops", "RangeTo"];
pub const REGEX_NEW_PATH: [&'static str; 3] = ["regex", "Regex", "new"];
pub const RESULT_PATH: [&'static str; 3] = ["core", "result", "Result"];
pub const STRING_PATH: [&'static str; 3] = ["collections", "string", "String"];
pub const TRANSMUTE_PATH: [&'static str; 3] = ["core", "intrinsics", "transmute"];
pub const TRANSMUTE_PATH: [&'static str; 4] = ["core", "intrinsics", "", "transmute"];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one is weird.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what caused this, and if it's a bug. @eddyb?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it could happen otherwise and match_def_path needs more work or if it’s just an intrinsics weirdness.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably is intrinsics weirdness, but match_def_path is pretty simple so it's likely that the path is just weird. Which might be a "bug" given that paths probably shouldn't work that way.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turning a DefPath into a string still has some weirdnesses, such as not skipping the extern {...} item (and some impl-related stuff).

@Manishearth
Copy link
Member

This was merged Manishearth@76a831c

@Manishearth Manishearth closed this Apr 8, 2016
@mcarton mcarton deleted the rustup branch April 8, 2016 09:40
@mcarton
Copy link
Member Author

mcarton commented Apr 8, 2016

Oh, a “Verified” tag. Is that the only reason you amended the commit or I am missing something here? 😄

@Manishearth
Copy link
Member

Well, I meant to stick it onto the merge commit, but this was an ff merge with no merge commit so it accidentally signed yours instead.

I've started signing my commits and plan to sign clippy releases, perhaps with a short changelog.

@mcarton
Copy link
Member Author

mcarton commented Apr 8, 2016

Well, I meant to stick it onto the merge commit, but this was an ff merge with no merge commit so it accidentally signed yours instead.

So soon in the morning, I wasn’t sure I wasn’t missing something :D

perhaps with a short changelog

I’ve kept a list of rustups and new lints for a while with the intention make a changelog file, but I never did. Let me markdownify that and I’ll make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants