From 14453cacfb1fc9b7b3f30b6356e70a3416d26a56 Mon Sep 17 00:00:00 2001 From: Nicholas Nethercote Date: Thu, 15 Feb 2024 16:22:22 +1100 Subject: [PATCH] Remove `SharedEmitterMessage::AbortIfErrors`. It's always paired wth `SharedEmitterMessage::Diagnostic`, so the two can be merged. --- compiler/rustc_codegen_ssa/src/back/write.rs | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/compiler/rustc_codegen_ssa/src/back/write.rs b/compiler/rustc_codegen_ssa/src/back/write.rs index d9a7d51635cd8..502aac47c0eb4 100644 --- a/compiler/rustc_codegen_ssa/src/back/write.rs +++ b/compiler/rustc_codegen_ssa/src/back/write.rs @@ -1783,7 +1783,6 @@ fn spawn_work<'a, B: ExtraBackendMethods>( enum SharedEmitterMessage { Diagnostic(Diagnostic), InlineAsmError(u32, String, Level, Option<(String, Vec)>), - AbortIfErrors, Fatal(String), } @@ -1852,7 +1851,6 @@ impl Emitter for SharedEmitter { args, })), ); - drop(self.sender.send(SharedEmitterMessage::AbortIfErrors)); } fn source_map(&self) -> Option<&Lrc> { @@ -1894,6 +1892,7 @@ impl SharedEmitterMain { .collect(); d.replace_args(diag.args); dcx.emit_diagnostic(d); + sess.dcx().abort_if_errors(); } Ok(SharedEmitterMessage::InlineAsmError(cookie, msg, level, source)) => { assert!(matches!(level, Level::Error | Level::Warning | Level::Note)); @@ -1926,9 +1925,6 @@ impl SharedEmitterMain { err.emit(); } - Ok(SharedEmitterMessage::AbortIfErrors) => { - sess.dcx().abort_if_errors(); - } Ok(SharedEmitterMessage::Fatal(msg)) => { sess.dcx().fatal(msg); }