From 05e4116af2e015ebafcfb18b3db21c25ef9c7c99 Mon Sep 17 00:00:00 2001 From: Marcus Klaas Date: Sun, 3 Apr 2016 22:30:21 +0200 Subject: [PATCH] Fix the span for try shorthand expressions --- src/libsyntax/parse/parser.rs | 2 +- .../compile-fail/symbol-names/issue-32709.rs | 20 +++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) create mode 100644 src/test/compile-fail/symbol-names/issue-32709.rs diff --git a/src/libsyntax/parse/parser.rs b/src/libsyntax/parse/parser.rs index 9027a5b107452..f4a426849652d 100644 --- a/src/libsyntax/parse/parser.rs +++ b/src/libsyntax/parse/parser.rs @@ -2576,7 +2576,7 @@ impl<'a> Parser<'a> { loop { // expr? while self.eat(&token::Question) { - let hi = self.span.hi; + let hi = self.last_span.hi; e = self.mk_expr(lo, hi, ExprKind::Try(e), None); } diff --git a/src/test/compile-fail/symbol-names/issue-32709.rs b/src/test/compile-fail/symbol-names/issue-32709.rs new file mode 100644 index 0000000000000..f9d11f3a171c2 --- /dev/null +++ b/src/test/compile-fail/symbol-names/issue-32709.rs @@ -0,0 +1,20 @@ +// Copyright 2016 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +#![feature(question_mark)] + +// Make sure that the span of try shorthand does not include the trailing +// semicolon; +fn a() -> Result { + Err(5)?; //~ ERROR 16:5: 16:12 + Ok(1) +} + +fn main() {}