Skip to content

Commit

Permalink
auto merge of #13782 : alexcrichton/rust/issue-13775, r=pcwalton
Browse files Browse the repository at this point in the history
These often crop up when using default methods that don't actually bind their
argument names.

Closes #13775
  • Loading branch information
bors committed May 5, 2014
2 parents d943b0f + cf9dd70 commit 600507d
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/librustc/middle/lint.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1270,7 +1270,7 @@ fn check_pat_uppercase_variable(cx: &Context, p: &ast::Pat) {
// last identifier alone is right choice for this lint.
let ident = path.segments.last().unwrap().identifier;
let s = token::get_ident(ident);
if s.get().char_at(0).is_uppercase() {
if s.get().len() > 0 && s.get().char_at(0).is_uppercase() {
cx.span_lint(
UppercaseVariables,
path.span,
Expand Down
15 changes: 15 additions & 0 deletions src/test/run-pass/issue-13775.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

trait Foo {
fn bar(&self, int) {}
}

fn main() {}

0 comments on commit 600507d

Please sign in to comment.