From 3ca4d92cd6794638fe862a3046245a878b605d93 Mon Sep 17 00:00:00 2001 From: Ariel Ben-Yehuda Date: Sat, 13 Jun 2015 17:59:10 +0300 Subject: [PATCH] Ensure projections are not counted as constraining type parameters. Fixes #26262 --- .../constrained_type_params.rs | 17 ++++++++-- src/test/compile-fail/issue-26262.rs | 32 +++++++++++++++++++ 2 files changed, 46 insertions(+), 3 deletions(-) create mode 100644 src/test/compile-fail/issue-26262.rs diff --git a/src/librustc_typeck/constrained_type_params.rs b/src/librustc_typeck/constrained_type_params.rs index 09539931c3446..b1580a74876c1 100644 --- a/src/librustc_typeck/constrained_type_params.rs +++ b/src/librustc_typeck/constrained_type_params.rs @@ -19,10 +19,21 @@ pub enum Parameter { Region(ty::EarlyBoundRegion), } +/// Returns the list of parameters that are constrained by the type `ty` +/// - i.e. the value of each parameter in the list is uniquely determined +/// by `ty` (see RFC 447). pub fn parameters_for_type<'tcx>(ty: Ty<'tcx>) -> Vec { - ty.walk() - .flat_map(|ty| parameters_for_type_shallow(ty)) - .collect() + let mut result = vec![]; + ty::maybe_walk_ty(ty, |t| { + if let ty::TyProjection(..) = t.sty { + false // projections are not injective. + } else { + result.append(&mut parameters_for_type_shallow(t)); + // non-projection type constructors are injective. + true + } + }); + result } pub fn parameters_for_trait_ref<'tcx>(trait_ref: &ty::TraitRef<'tcx>) -> Vec { diff --git a/src/test/compile-fail/issue-26262.rs b/src/test/compile-fail/issue-26262.rs new file mode 100644 index 0000000000000..8d79fd4570d34 --- /dev/null +++ b/src/test/compile-fail/issue-26262.rs @@ -0,0 +1,32 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// Check that projections don't count as constraining type parameters. + +struct S(T); + +trait Tr { type Assoc; fn test(); } + +impl S { +//~^ ERROR the type parameter `T` is not constrained + fn foo(self, _: T) { + T::test(); + } +} + +trait Trait1 { type Bar; } +trait Trait2<'x> { type Foo; } + +impl<'a,T: Trait2<'a>> Trait1<>::Foo> for T { +//~^ ERROR the lifetime parameter `'a` is not constrained + type Bar = &'a (); +} + +fn main() {}