Skip to content

size hint not taking effect in unzip #33468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kindlychung opened this issue May 6, 2016 · 1 comment
Closed

size hint not taking effect in unzip #33468

kindlychung opened this issue May 6, 2016 · 1 comment

Comments

@kindlychung
Copy link
Contributor

See here and here
@bluss
Copy link
Member

bluss commented May 7, 2016

We should simply remove the SizeHint hack since it does not follow the rules for a sensible Iterator impl. Specialization can then be used to implement this even better.

@ollie27 ollie27 mentioned this issue Jun 7, 2016
Merged
bors added a commit that referenced this issue Jun 21, 2016
@bors
Auto merge of #34155 - ollie27:unzip, r=alexcrichton
fe96928 
Remove unzip() SizeHint hack

This was using an invalid iterator so is likely to end with buggy
behaviour.

It also doesn't even benefit many type in std including Vec so removing it
shouldn't cause any problems.

Fixes: #33468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kindlychung @bluss @apasel422