[1.38] Regression: failed to resolve: use of undeclared type or module SliceConcatExt

[petrochenkov]

#63628 (comment)

failed to resolve: use of undeclared type or module SliceConcatExt

./gh/echupriyanov/tls-ws/beta-2019-08-13.txt:[INFO] [stderr] error[E0433]: failed to resolve: use of undeclared type or module `SliceConcatExt`

SliceConcatExt was an unstable standard library trait removed in #62403.

[Mark-Simulacrum]

Closing as expected breakage (cc @rust-lang/libs, but this is so minimally breaking and was an unstable use).

[SimonSapin]

Ouch, it turns out an unstable trait in the prelude can be named without any #![feature(…)] opt-in.

https://github.com/echupriyanov/tls-ws/blob/d458e2edfabc7e28494482987afbb5eebba1de7f/src/bin/server.rs#L117 reduced:

fn main() {
    dbg!(SliceConcatExt::join(&["foo", "bar"][..], "-"));
}

Not to say that we should revert or do anything else here, but to keep in mind next time we consider adding an unstable trait in the prelude. Or should we consider that a compiler bug?

[Mark-Simulacrum]

Yeah, looks like a compiler bug (probably similar to the other stability problems with 'absolute' paths -- if we're importing it for you it probably bypasses stability by looking like a root path?