Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking Issue for cfg(target_has_atomic_load_store) #94039

Open
3 tasks
Mark-Simulacrum opened this issue Feb 16, 2022 · 2 comments
Open
3 tasks

Tracking Issue for cfg(target_has_atomic_load_store) #94039

Mark-Simulacrum opened this issue Feb 16, 2022 · 2 comments
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. S-tracking-design-concerns Status: There are blocking design concerns. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Feb 16, 2022

The feature gate for the issue is #![feature(cfg_target_has_atomic)].

About tracking issues

Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

  • Do we need a separate cfg for load/store operations, in combination with the existing cfg(target_has_atomic = ...)? (Or is cfg(accessible) enough?)
@Mark-Simulacrum Mark-Simulacrum added T-lang Relevant to the language team, which will review and decide on the PR/issue. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. S-tracking-design-concerns Status: There are blocking design concerns. labels Feb 16, 2022
@josephlr
Copy link
Contributor

josephlr commented Jul 18, 2022

I think the name of this feature is wrong, using it gives:

error[E0635]: unknown feature `cfg_target_has_atomic_load_store`
 --> src/lib.rs:5:12
  |
5 | #![feature(cfg_target_has_atomic_load_store)]
  |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

It seems like the #[cfg(target_has_atomic_load_store = ...)] functionality still uses #![feature(cfg_target_has_atomic)]

EDIT: Note that I think the current behavior is fine, we should just update the tracking issue (as opposed to renaming a feature already in use).

@RalfJung RalfJung changed the title Tracking Issue for cfg_target_has_atomic_load_store Tracking Issue for cfg(target_has_atomic_load_store Oct 1, 2024
@RalfJung RalfJung changed the title Tracking Issue for cfg(target_has_atomic_load_store Tracking Issue for cfg(target_has_atomic_load_store) Oct 1, 2024
@RalfJung
Copy link
Member

RalfJung commented Oct 1, 2024

Is there anything else guarded under cfg_target_has_atomic, besides cfg(target_has_atomic_load_store)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. S-tracking-design-concerns Status: There are blocking design concerns. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants