Skip to content

Remove expr_parentheses_needed from ParseSess #102500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2022
Merged

Remove expr_parentheses_needed from ParseSess #102500

merged 1 commit into from
Oct 1, 2022

Conversation

@compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Sep 30, 2022

Not sure why this method needed to exist on ParseSess, but we can achieve the same behavior by just inlining it everywhere.

@compiler-errors compiler-errors added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Sep 30, 2022
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 30, 2022
@rust-highfive
Copy link
Contributor

rust-highfive commented Sep 30, 2022

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 30, 2022
@cjgillot
Copy link
Contributor

cjgillot commented Oct 1, 2022

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 1, 2022

📌 Commit 85a726e has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 1, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 1, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 1, 2022
@bors
Auto merge of rust-lang#102545 - matthiaskrgr:rollup-13i3tc3, r=matth…
56a35bc 
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#101675 (Improve `File::set_times` error handling)
 - rust-lang#102500 (Remove `expr_parentheses_needed` from `ParseSess`)
 - rust-lang#102533 (rustdoc: remove unused CSS selector `a.source`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit cc009bc into rust-lang:master Oct 1, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 1, 2022
@compiler-errors compiler-errors deleted the parse-sess-cleanup branch November 2, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cjgillot cjgillot

Labels

C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.66.0

Development

Successfully merging this pull request may close these issues.

5 participants

@compiler-errors @rust-highfive @cjgillot @bors @rustbot