From 835a102dd32f6c95951f5d1f19bc121a8fa6fb7d Mon Sep 17 00:00:00 2001 From: Michael Howell Date: Sat, 1 Oct 2022 10:40:16 -0700 Subject: [PATCH 1/2] rustdoc: remove no-op CSS `.impl { flex-basis: 100% }` etc When `.impl-items { flex-basis: 100% }` and `h3.impl, h3.method, h4.method, h3.type, h4.type, h4.associatedconstant` were added in 34bd2b845b3acd84c5a9bddae3ff8081c19ec5e9, it seems like it was a mistake even then. According to MDN, [flex-basis] does nothing unless the box it's applied to is a flex *item*, a child of a flex container. However, when this was added, these elements were flex containers themselves. [flex-basis]: https://developer.mozilla.org/en-US/docs/Web/CSS/flex-basis --- src/librustdoc/html/static/css/rustdoc.css | 1 - 1 file changed, 1 deletion(-) diff --git a/src/librustdoc/html/static/css/rustdoc.css b/src/librustdoc/html/static/css/rustdoc.css index 84e6df59f576b..d8364ec472077 100644 --- a/src/librustdoc/html/static/css/rustdoc.css +++ b/src/librustdoc/html/static/css/rustdoc.css @@ -193,7 +193,6 @@ h4.code-header { .methods .associatedconstant, .impl-items .associatedtype, .methods .associatedtype { - flex-basis: 100%; position: relative; } From d46e558a93a281a9e41a35cb181a375df388f60c Mon Sep 17 00:00:00 2001 From: Michael Howell Date: Sat, 1 Oct 2022 10:42:13 -0700 Subject: [PATCH 2/2] rustdoc: remove no-op CSS `.impl { position: relative }` etc This property was added to help with positioning the `[+]/[-]` toggle. It is no longer necessary, because `details.rustdoc-toggle` already has `position:relative` set on it. --- src/librustdoc/html/static/css/rustdoc.css | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/librustdoc/html/static/css/rustdoc.css b/src/librustdoc/html/static/css/rustdoc.css index d8364ec472077..f67d580e28e82 100644 --- a/src/librustdoc/html/static/css/rustdoc.css +++ b/src/librustdoc/html/static/css/rustdoc.css @@ -184,17 +184,6 @@ h4.code-header { margin: 0; padding: 0; } -.impl, -.impl-items .method, -.methods .method, -.impl-items .type, -.methods .type, -.impl-items .associatedconstant, -.methods .associatedconstant, -.impl-items .associatedtype, -.methods .associatedtype { - position: relative; -} #crate-search, h1, h2, h3, h4, h5, h6,