-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest ..= when someone tries to create an overflowing range #109554
Conversation
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
r? @scottmcm |
This suggestion seems OK, but keep in mind that using ..= has performance consequences (it often/sometimes gives slower code). |
@WaffleLapkin Something weird is that the first symbol
I finally chose to emits suggestions separately. Luckily, the test results look good. Please let me know if the behavior above is known or unexpected. Thanks! ;) |
I'm not familiar enough with lint patterns to be a good reviewer here, so let's say since they commented already. EDIT: good job, self -- I should look at to whom it's actually assigned, not just read the |
Could not assign reviewer from: |
This comment was marked as resolved.
This comment was marked as resolved.
This looks fine to me, modulo |
@bors r+ rollup |
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#107387 (Use random `HashMap` keys on Hermit) - rust-lang#109511 (Make `EvalCtxt`'s `infcx` private) - rust-lang#109554 (Suggest ..= when someone tries to create an overflowing range) - rust-lang#109675 (Do not consider elaborated projection predicates for objects in new solver) - rust-lang#109693 (Remove ~const from alloc) - rust-lang#109700 (Lint against escape sequences in Fluent files) - rust-lang#109716 (Move `mir::Field` → `abi::FieldIdx`) - rust-lang#109726 (rustdoc: Don't strip crate module) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #109529