Revert "Don't recover lifetimes/labels containing emojis as character literals" #110135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… literals" Reverts PR rust-lang#108031 Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
|
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
compiler-errors
added
the
beta-nominated
|
@bors r=davidtwco |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 10, 2023
…avidtwco Revert "Don't recover lifetimes/labels containing emojis as character literals" Reverts PR rust-lang#108031 per rust-lang#109754 (comment) Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Apr 11, 2023
…avidtwco Revert "Don't recover lifetimes/labels containing emojis as character literals" Reverts PR rust-lang#108031 per rust-lang#109754 (comment) Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Apr 11, 2023
…avidtwco Revert "Don't recover lifetimes/labels containing emojis as character literals" Reverts PR rust-lang#108031 per rust-lang#109754 (comment) Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Apr 11, 2023
…avidtwco Revert "Don't recover lifetimes/labels containing emojis as character literals" Reverts PR rust-lang#108031 per rust-lang#109754 (comment) Fixes (doesnt close until beta backported) rust-lang#109746 This reverts commit e3f9db5. This reverts commit 98b82ae. This reverts commit 380fa26.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#109810 (Replace rustdoc-ui/{c,z}-help tests with a stable run-make test ) - rust-lang#110035 (fix: ensure bad `#[test]` invocs retain correct AST) - rust-lang#110089 (sync::mpsc: synchronize receiver disconnect with initialization) - rust-lang#110103 (Report overflows gracefully with new solver) - rust-lang#110122 (Fix x check --stage 1 when download-ci-llvm=false) - rust-lang#110133 (Do not use ImplDerivedObligationCause for inherent impl method error reporting) - rust-lang#110135 (Revert "Don't recover lifetimes/labels containing emojis as character literals") - rust-lang#110235 (Fix `--extend-css` option) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
rustbot
added
the
beta-accepted
pietroalbini
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2023
…troalbini [stable] Prepare Rust 1.69.0 Last minute backports: * rust-lang#109643 * rust-lang#110135 * rust-lang#109938 * rust-lang#109937 * rust-lang#109266 This PR also bumps the channel to stable, and backports the release notes from master. r? `@ghost` cc `@rust-lang/release`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts PR #108031 per #109754 (comment)
Fixes (doesnt close until beta backported) #109746
This reverts commit e3f9db5.
This reverts commit 98b82ae.
This reverts commit 380fa26.