Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable some ignored test cases #12165

Merged
merged 1 commit into from
Feb 13, 2014
Merged

Conversation

fhahn
Copy link
Contributor

@fhahn fhahn commented Feb 10, 2014

While working on #11363 I stumbled over a couple of ignored tests, that seem to be fixed or invalid.

@brson
Copy link
Contributor

brson commented Feb 11, 2014

Needs rebase.

@fhahn
Copy link
Contributor Author

fhahn commented Feb 11, 2014

I've rebased with the current master and pushed an updated commit

@fhahn
Copy link
Contributor Author

fhahn commented Feb 12, 2014

It seems like there was a problem with using let mut table = std::hashmap::HashMap::new();. I've changed the code to use use std::hashmap::HashMap.

* src/test/run-pass/issue-3559.rs was fixed in rust-lang#4726
* src/test/compile-fail/borrowck-call-sendfn.rs was fixed in rust-lang#2978
* update src/test/compile-fail/issue-5500-1.rs to work with current Rust
* removed src/test/compile-fail/issue-5500.rs because it is tested in
    src/test/run-fail/issue-5500.rs
* src/test/compile-fail/view-items-at-top.rs fixed
* rust-lang#897 fixed
* compile-fail/issue-6762.rs issue was closed as dup of rust-lang#6801
* deleted compile-fail/issue-2074.rs because it became irelevant and is
  irrelevant rust-lang#2074, a test covering this was added in
  4f92f45
bors added a commit that referenced this pull request Feb 12, 2014
While working on #11363 I stumbled over a couple of ignored tests, that seem to be fixed or invalid.

* src/test/run-pass/issue-3559.rs was fixed in #4726
* src/test/compile-fail/borrowck-call-sendfn.rs was fixed in #2978
* update src/test/compile-fail/issue-5500-1.rs to work with current Rust (I'm not 100% sure if the original condition is tested as mentioned in #5500, but I think so)
* removed src/test/compile-fail/issue-5500.rs because it is tested in
    src/test/run-fail/issue-5500.rs (they are the same test cases, I just renamed src/test/run-fail/addr-of-bot.rs to be consistent with the other issue name
@bors bors closed this Feb 13, 2014
@bors bors merged commit 195d8fd into rust-lang:master Feb 13, 2014
@fhahn fhahn deleted the change-some-tests branch February 13, 2014 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants