Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #5121: Add proper support for early/late distinction for lifetime bindings #12807

Merged
merged 6 commits into from
Mar 12, 2014
Merged

Fix issue #5121: Add proper support for early/late distinction for lifetime bindings #12807

merged 6 commits into from
Mar 12, 2014

Commits on Mar 12, 2014

  1. Port partition method from ~[T] to Vec<T>, for use early-late lifetim… 

    …e code.
    @pnkfelix
    pnkfelix committed Mar 12, 2014
    Configuration menu
    Copy the full SHA
    da19563 View commit details
    Browse the repository at this point in the history

  2. Alpha-rename .ident fields of type Name to .name.

    @pnkfelix
    pnkfelix committed Mar 12, 2014
    Configuration menu
    Copy the full SHA
    460ca4f View commit details
    Browse the repository at this point in the history

  3. alpha-rename .ident to .name in Lifetime, including in rustdoc.

    @pnkfelix
    pnkfelix committed Mar 12, 2014
    Configuration menu
    Copy the full SHA
    189c008 View commit details
    Browse the repository at this point in the history

  4. Introduce Scope<'a> shorthand for &'a ScopeChain<'a>.

    @pnkfelix
    pnkfelix committed Mar 12, 2014
    Configuration menu
    Copy the full SHA
    28ebec5 View commit details
    Browse the repository at this point in the history

  5. Changed lists of lifetimes in ast and ty to use Vec instead of OptVec. 

    There is a broader revision (that does this across the board) pending
in rust-lang#12675, but that is awaiting the arrival of more data (to decide
whether to keep OptVec alive by using a non-Vec internally).

For this code, the representation of lifetime lists needs to be the
same in both ScopeChain and in the ast and ty structures.  So it
seemed cleanest to just use `vec_ng::Vec`, now that it has a cheaper
empty representation than the current `vec` code.
    @pnkfelix
    pnkfelix committed Mar 12, 2014
    Configuration menu
    Copy the full SHA
    586b619 View commit details
    Browse the repository at this point in the history

  6. Add proper support for early/late distinction for lifetime bindings. 

    Uses newly added Vec::partition method to simplify resolve_lifetime.
    @pnkfelix
    pnkfelix committed Mar 12, 2014
    11 Configuration menu
    Copy the full SHA
    742e458 View commit details
    Browse the repository at this point in the history