Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #130165

Merged
merged 36 commits into from
Sep 9, 2024
Merged

Rollup of 9 pull requests #130165

merged 36 commits into from
Sep 9, 2024

Commits on Sep 7, 2024

  1. Configuration menu
    Copy the full SHA
    46115fd View commit details
    Browse the repository at this point in the history
  2. Remove now redundant check in symlink_hard_link test

    We support macOS 10.12 and above, so it now always uses linkat, so the
    check is redundant.
    
    This was missed in rust-lang#126351.
    madsmtm committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    a6c6eda View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Reduce visibilities, and add warn(unreachable_pub).

    Lots of unnecessary `pub`s in this crate. Most are downgraded to
    `pub(super)`, though some don't need any visibility.
    nnethercote committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    6af470e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cd9fd27 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Add an explicit ignore message for "up-to-date" tests

    When running tests without the `--force-rerun` flag, compiletest will
    automatically skip any tests that (in its judgement) don't need to be run again
    since the last time they were run.
    
    This patch adds an explicit reason to those skipped tests, which is visible
    when running with `rust.verbose-tests = true` in `config.toml`.
    Zalathar committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a6735e4 View commit details
    Browse the repository at this point in the history
  2. Streamline AbortUnwindingCalls.

    Currently it constructs two vectors `calls_to_terminated` and
    `cleanups_to_remove` in the main loop, and then processes them after the
    main loop. But the processing can be done in the main loop, avoiding the
    need for the vectors.
    nnethercote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ec6fe4e View commit details
    Browse the repository at this point in the history
  3. Simplify verify_candidate_branch.

    Let chains are perfect for this kind of function.
    nnethercote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    cc09ab3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    181fbd5 View commit details
    Browse the repository at this point in the history
  5. Remove an unnecessary continue.

    Nothing comes after it within the loop.
    nnethercote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4f2588f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9cf90b9 View commit details
    Browse the repository at this point in the history
  7. Make CallSite non-Copy.

    It doesn't need to be, and it's 72 bytes on 64-bit platforms, which is
    fairly large.
    nnethercote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    7adde3f View commit details
    Browse the repository at this point in the history
  8. Use LocalDecls in a couple of places.

    It's nicer than the `IndexVec` type.
    nnethercote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    751c8b4 View commit details
    Browse the repository at this point in the history
  9. Improve consistency in LowerIntrinsics.

    In some cases `target` and `arg` are obtained fallibly, and in some
    cases they are obtained infallibly. This commit changes them all to
    infallible.
    nnethercote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5445953 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    acccb39 View commit details
    Browse the repository at this point in the history
  11. Remove unnecessary lifetimes in dataflow structs.

    There are four related dataflow structs: `MaybeInitializedPlaces`,
    `MaybeUninitializedPlaces`, and `EverInitializedPlaces`,
    `DefinitelyInitializedPlaces`. They all have a `&Body` and a
    `&MoveData<'tcx>` field. The first three use different lifetimes for the
    two fields, but the last one uses the same lifetime for both.
    
    This commit changes the first three to use the same lifetime, removing
    the need for one of the lifetimes. Other structs that also lose a
    lifetime as a result of this are `LivenessContext`, `LivenessResults`,
    `InitializationData`.
    
    It then does similar things in various other structs.
    nnethercote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    3fe7dd6 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    bed91f5 View commit details
    Browse the repository at this point in the history
  13. Remove unnecessary lifetime from OperandCollector.

    Also put the remaining lifetimes into the usual order.
    nnethercote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    1aafeb2 View commit details
    Browse the repository at this point in the history
  14. Rename some lifetimes.

    Give them the names used in most places.
    nnethercote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    28a6dc4 View commit details
    Browse the repository at this point in the history
  15. Remove Gatherer.

    It's a very thin wrapper that pairs `MoveDataBuilder` with a `Location`,
    and it has four lifetime arguments. This commit removes it by just
    adding a `Location` to `MoveDataBuilder`.
    nnethercote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    dc62f07 View commit details
    Browse the repository at this point in the history
  16. Remove Elaborator.

    It's a trivial wrapper around `ElaborateDropsCtxt` that serves no
    apparent purpose.
    nnethercote committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    0b032f8 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    5c35027 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    0f8efb3 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    e186cc6 View commit details
    Browse the repository at this point in the history
  20. use verbose flag as a default value for rust.verbose-tests

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    19b8f9e View commit details
    Browse the repository at this point in the history
  21. Stabilize char::MIN

    okaneco committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    bc70fa2 View commit details
    Browse the repository at this point in the history
  22. update rust.verbose-tests doc in config.example.toml

    Signed-off-by: onur-ozkan <work@onurozkan.dev>
    onur-ozkan committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    13ea104 View commit details
    Browse the repository at this point in the history
  23. Update books

    rustbot committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    8b052ea View commit details
    Browse the repository at this point in the history
  24. Rollup merge of rust-lang#129929 - nnethercote:rustc_mir_transform-cl…

    …eanups-2, r=cjgillot
    
    `rustc_mir_transform` cleanups, round 2
    
    More cleanups in the style of rust-lang#129738.
    
    r? ``@cjgillot``
    matthiaskrgr authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    3e3b148 View commit details
    Browse the repository at this point in the history
  25. Rollup merge of rust-lang#130022 - nnethercote:dataflow-borrowck-life…

    …times, r=oli-obk
    
    Dataflow/borrowck lifetime cleanups
    
    These commits remove a bunch of unnecessary lifetimes from structs involved in dataflow/borrowck.
    
    r? ``@lqd``
    matthiaskrgr authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    ee8fd33 View commit details
    Browse the repository at this point in the history
  26. Rollup merge of rust-lang#130064 - folkertdev:fix-issue-129983, r=com…

    …piler-errors
    
    fix ICE in CMSE type validation
    
    fixes rust-lang#129983
    
    tracking issue: rust-lang#81391
    
    r? ``@compiler-errors``
    matthiaskrgr authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    1490fe6 View commit details
    Browse the repository at this point in the history
  27. Rollup merge of rust-lang#130067 - madsmtm:clean-up-fs-test, r=ChrisD…

    …enton
    
    Remove redundant check in `symlink_hard_link` test
    
    We support macOS 10.12 and above, so it now always uses `linkat`, and so the check is redundant.
    
    This was missed in rust-lang#126351.
    
    ``@rustbot`` label O-macos
    matthiaskrgr authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    2d26ebe View commit details
    Browse the repository at this point in the history
  28. Rollup merge of rust-lang#130131 - Zalathar:up-to-date, r=Kobzol

    Print a helpful message if any tests were skipped for being up-to-date
    
    When running tests without the `--force-rerun` flag, compiletest will automatically skip any tests that (in its judgement) don't need to be run again since the last time they were run.
    
    This is normally very useful, but can occasionally be confusing, especially in edge-cases where up-to-date checking is not completely accurate (or the test is flaky).
    
    This PR makes bootstrap count the number of tests that were ignored for being up-to-date (via a hard-coded check on the ignore reason), and prints a helpful message when that number is nonzero.
    
    ---
    
    Sample output:
    
    ```text
    test result: ok. 4 passed; 0 failed; 17578 ignored; 0 measured; 0 filtered out; finished in 463.79ms
    
    help: ignored 17295 up-to-date tests; use `--force-rerun` to prevent this
    
    Build completed successfully in 0:00:07
    ```
    matthiaskrgr authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    3658bfb View commit details
    Browse the repository at this point in the history
  29. Rollup merge of rust-lang#130137 - gurry:master, r=cjgillot

    Fix ICE caused by missing span in a region error
    
    Fixes rust-lang#130012
    
    The ICE occurs on line 634 in this error handling code: https://github.com/rust-lang/rust/blob/085744b7ad8b227239bcee0a44cd78dcd0310ab9/compiler/rustc_trait_selection/src/error_reporting/infer/region.rs#L617-L637 It is caused by the span being a dummy span and `!span.is_dummy()` on line 628 evaluating to `false`.
    
    A dummy span, however, is expected here thanks to the `Self: Trait` predicate from `predicates_of` (see line 61): https://github.com/rust-lang/rust/blob/085744b7ad8b227239bcee0a44cd78dcd0310ab9/compiler/rustc_hir_analysis/src/collect/predicates_of.rs#L61-L69
    
    This PR changes the error handling code to omit the note which needed the span instead of ICE'ing in the presence of a dummy span.
    matthiaskrgr authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    3b0221b View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    7c109b1 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    72b0f5b View commit details
    Browse the repository at this point in the history
  32. Rollup merge of rust-lang#130158 - rustbot:docs-update, r=ehuss

    Update books
    
    ## rust-lang/edition-guide
    
    1 commits in eeba2cb9c37ab74118a4fb5e5233f7397e4a91f8..b3ca7ade0f87d7e3fb538776defc5b2cc4188172
    2024-09-03 22:59:56 UTC to 2024-09-03 22:59:56 UTC
    
    - Rename `static_mut_refs` file to plural
    
    ## rust-embedded/book
    
    1 commits in ff5d61d56f11e1986bfa9652c6aff7731576c37d..dbae36bf3f8410aa4313b3bad42e374735d48a9d
    2024-09-04 20:49:11 UTC to 2024-09-04 20:49:11 UTC
    
    - Fix small error in c bindings (rust-embedded/book#377)
    
    ## rust-lang/reference
    
    6 commits in 0668397076da350c404dadcf07b6cbc433ad3743..687faf9958c52116d003b41dfd29cc1cf44f5311
    2024-09-03 20:21:23 UTC to 2024-08-29 01:11:29 UTC
    
    - `asm!`: clarify that `nomem` / `readonly` can access private memory (rust-lang/reference#1598)
    - Switch warning blocks to use admonitions (rust-lang/reference#1595)
    - dont use stdcall on x86_64 where it is not a valid ABI (rust-lang/reference#1600)
    - Add capturing and precise capturing rules (rust-lang/reference#1577)
    - Add a prefix to rule HTML IDs (rust-lang/reference#1593)
    - Add a description of rule identifiers (rust-lang/reference#1594)
    
    ## rust-lang/rust-by-example
    
    2 commits in 859786c5bc99301bbc22fc631a5c2b341860da08..c79ec345f08a1e94494cdc8c999709a90203fd88
    2024-09-08 13:24:48 UTC to 2024-09-08 13:24:08 UTC
    
    - Fix typo in conversion/from_into (rust-lang/rust-by-example#1882)
    - Corrected x values for example rectangle (rust-lang/rust-by-example#1884)
    
    ## rust-lang/rustc-dev-guide
    
    9 commits in fa928a6d19e1666d8d811dfe3fd35cdad3b4e459..0ed9229f5b6f7824b333beabd7e3d5ba4b9bd971
    2024-09-09 10:58:45 UTC to 2024-08-31 13:02:08 UTC
    
    - fix some comments (rust-lang/rustc-dev-guide#2059)
    - Fix a link and create an implied internal link  (rust-lang/rustc-dev-guide#2051)
    - link to additional LLVM update PRs (rust-lang/rustc-dev-guide#2055)
    - fix/improve rdg contributing howto (rust-lang/rustc-dev-guide#2056)
    - fixed the typo (rust-lang/rustc-dev-guide#2058)
    - fix typo maker -> marker (thanks `@lholten)` (rust-lang/rustc-dev-guide#2057)
    - improve query system documentation (rust-lang/rustc-dev-guide#2041)
    - add section on overlap checks (rust-lang/rustc-dev-guide#2042)
    - clarify the role of rustc_const_unstable (rust-lang/rustc-dev-guide#2045)
    matthiaskrgr authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    a0346bb View commit details
    Browse the repository at this point in the history