From 6ace653a2f314f0fec3001d9ff49b7fd181b14ad Mon Sep 17 00:00:00 2001 From: Ralf Jung Date: Tue, 17 Dec 2024 07:35:21 +0100 Subject: [PATCH 1/2] bootstrap: fix a comment --- src/bootstrap/src/core/builder/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bootstrap/src/core/builder/mod.rs b/src/bootstrap/src/core/builder/mod.rs index 026c26479d355..108deaf577fa6 100644 --- a/src/bootstrap/src/core/builder/mod.rs +++ b/src/bootstrap/src/core/builder/mod.rs @@ -622,7 +622,7 @@ impl<'a> ShouldRun<'a> { /// /// This differs from [`path`] in that multiple calls to path will end up calling `make_run` /// multiple times, whereas a single call to `paths` will only ever generate a single call to - /// `paths`. + /// `make_run`. /// /// This is analogous to `all_krates`, although `all_krates` is gone now. Prefer [`path`] where possible. /// From 7dbfe4d4cf3c95d2d3cdbdae61b7888dcda0bdf6 Mon Sep 17 00:00:00 2001 From: Ralf Jung Date: Tue, 17 Dec 2024 07:37:46 +0100 Subject: [PATCH 2/2] clarify that path() is for on-disk paths --- src/bootstrap/src/core/builder/mod.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/bootstrap/src/core/builder/mod.rs b/src/bootstrap/src/core/builder/mod.rs index 108deaf577fa6..98f765dbd0f5c 100644 --- a/src/bootstrap/src/core/builder/mod.rs +++ b/src/bootstrap/src/core/builder/mod.rs @@ -613,7 +613,9 @@ impl<'a> ShouldRun<'a> { self } - // single, non-aliased path + /// single, non-aliased path + /// + /// Must be an on-disk path; use `alias` for names that do not correspond to on-disk paths. pub fn path(self, path: &str) -> Self { self.paths(&[path]) }