Offload intrinsic #147936
Offload intrinsic #147936
Conversation
rustbot
added
A-LLVM
Sa4dUs
force-pushed
the
offload-intrinsic
branch
from
9118683 to
23722aa
Compare
This comment has been minimized.
This comment has been minimized.
| } | ||
|
|
||
| pub fn from_ty<'tcx>(tcx: TyCtxt<'tcx>, ty: Ty<'tcx>) -> Self { | ||
| OffloadMetadata { payload_size: get_payload_size(tcx, ty), mode: TransferKind::Both } |
There was a problem hiding this comment.
If you already have the code here, I would add a small check for & or byVal (implies Mode ToGPU), vs &mut (implies Both).
In the future we would hope to analyze the & or byval case more, if we never read from it (before writing) then we could use a new mode 4, which allocates directly on the gpu.
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #148507) made this pull request unmergeable. Please resolve the merge conflicts. |
Sa4dUs
force-pushed
the
offload-intrinsic
branch
from
e0fd7be to
97a8e96
Compare
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #148721) made this pull request unmergeable. Please resolve the merge conflicts. |
| let i32_0 = cx.get_const_i32(0); | ||
| for index in 0..types.len() { | ||
| let v = unsafe { llvm::LLVMGetOperand(kernel_call, index as u32).unwrap() }; | ||
| for index in 0..num_args { |
There was a problem hiding this comment.
can you iterate directly over args now?
| return Ok(()); | ||
| } | ||
| sym::offload => { | ||
| // FIXME(Sa4dUs): emit error when offload is not enabled |
There was a problem hiding this comment.
I'd rather have that as a TODO, thus fixed before we land it. You can just copy the check I had above (and potentially error if you find an intrinsic, but not the flag set). The current main already requires it, and we shouldn't change nightly behaviour because of an experimental feature without a user setting a feature flag.
| | ty::FnDef(_, _) | ||
| | ty::FnPtr(_, _) | ||
| | ty::Closure(_, _) | ||
| | ty::CoroutineClosure(_, _) | ||
| | ty::Coroutine(_, _) | ||
| | ty::CoroutineWitness(_, _) | ||
| | ty::Never |
There was a problem hiding this comment.
I'd expect all of these to not be handled correctly by offload without further work, so I'd just error.
The same goes for
| ty::Bound(_, _)
| ty::Placeholder(_)
| ty::Infer(_)
| ty::Error(_)
5 participants
No description provided.