Skip to content

compiletest: rename add-core-stubs to add-minicore #148305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

compiletest: rename add-core-stubs to add-minicore #148305

wants to merge 1 commit into from
+297 −299

Conversation

@RalfJung
Copy link
Member

Fixes #148282

@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2025

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

Some changes occurred in tests/codegen-llvm/stack-probes-inline.rs

cc @rust-lang/project-exploit-mitigations, @rcvalle

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

Some changes occurred in tests/codegen-llvm/sanitizer

cc @rcvalle

Some changes occurred in tests/ui/sanitizer

cc @rcvalle

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2025

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jieyouxu jieyouxu self-assigned this Oct 30, 2025
@Urgau Urgau mentioned this pull request Oct 30, 2025
Open
5 tasks
wesleywiser
wesleywiser approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@wesleywiser wesleywiser left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I'll let @jieyouxu review as well before r+'ing

View changes since this review

@rust-log-analyzer

This comment has been minimized.

Sign in to view
jieyouxu
jieyouxu approved these changes Nov 1, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one nit, you can r=Wesley and me after.

View changes since this review

tests/ui/cmse-nonsecure/cmse-nonsecure-entry/return-via-stack.rs
//@ compile-flags: --target thumbv8m.main-none-eabi --crate-type lib
//@ needs-llvm-components: arm
//@ add-core-stubs
//@ add-minicore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: duplicate directive

(compiletest should error on this, #148359)

tests/ui/panic-runtime/need-immediate-abort-got-abort.rs
//@ no-prefer-dynamic
//@ add-core-stubs
//@ add-minicore
//@ core-stubs-compile-flags: -Zunstable-options -Cpanic=immediate-abort
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem: I realized that Saethlin recently added //@ core-stubs-compile-flags for overriding the flags used to build minicore. We should also rename this, but I'll do it in a follow-up, tracked in #148360.

@jieyouxu
Copy link
Member

jieyouxu commented Nov 1, 2025 •
edited
Loading

@bors p=10 (logically conflict-prone)

@jieyouxu
Copy link
Member

jieyouxu commented Nov 1, 2025

@bors rollup=never (logically conflict-prone)

@jieyouxu
Copy link
Member

jieyouxu commented Nov 1, 2025

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@wesleywiser wesleywiser

@jieyouxu jieyouxu

Labels

A-compiletest Area: The compiletest test runner A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracking issue for MCP 930: Rename //@ add-core-stubs to //@ add-minicore

5 participants

@RalfJung @rustbot @rust-log-analyzer @jieyouxu @wesleywiser