Skip to content

Constify DropGuard::into_inner and trait impls #148755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Constify DropGuard::into_inner and trait impls #148755

wants to merge 2 commits into from
+15 −6

Conversation

@nxsaken
Copy link
Contributor

@nxsaken nxsaken commented Nov 9, 2025 •
edited by rustbot
Loading

Feature: drop_guard (#144426), const_convert (#143773), const_drop_guard (no tracking issue yet)

Constifies DropGuard::into_inner and trait impls.
I reused const_convert (#143773) for the Deref* impls.

Blocked on #148752.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2025

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@joboet
Copy link
Member

joboet commented Nov 13, 2025

r? libs-api
@rustbot label +S-blocked -S-waiting-on-review

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Nov 13, 2025
@rustbot rustbot assigned the8472 and unassigned joboet Nov 13, 2025
@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@the8472 the8472

Labels

S-blocked Status: Blocked on something else such as an RFC or other implementation work. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nxsaken @rustbot @joboet @the8472