Skip to content

Add regression test for 128705 #149179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Nov 24, 2025
Merged

Add regression test for 128705 #149179

bors merged 1 commit into from
Nov 24, 2025

Conversation

@reddevilmidzy
Copy link
Contributor

@reddevilmidzy reddevilmidzy commented Nov 21, 2025 •
edited by rustbot
Loading

close: #128705

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 21, 2025
@reddevilmidzy reddevilmidzy marked this pull request as ready for review November 21, 2025 14:13
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 21, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Nov 22, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 22, 2025

📌 Commit a4ee7f8 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2025
@bors
Copy link
Collaborator

bors commented Nov 23, 2025

⌛ Testing commit a4ee7f8 with merge b7dd7f5...

bors added a commit that referenced this pull request Nov 23, 2025
@bors
Auto merge of #149179 - reddevilmidzy:test, r=JonathanBrouwer
b7dd7f5 
Add regression test for 128705

close: #128705
@bors
Copy link
Collaborator

bors commented Nov 23, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 23, 2025
@reddevilmidzy
Copy link
Contributor Author

reddevilmidzy commented Nov 23, 2025

@JonathanBrouwer What should I do to make bors build finidhed successful?

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Nov 23, 2025

I feel like one of the runners just borked itself, the queue is very empty so lets just try again
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 23, 2025

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: Fix typo in comment in rustc_errors #148882

@bors
Copy link
Collaborator

bors commented Nov 23, 2025

📌 Commit a4ee7f8 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2025
bend-n added a commit to bend-n/rust that referenced this pull request Nov 23, 2025
@bend-n
Rollup merge of rust-lang#149179 - reddevilmidzy:test, r=JonathanBrouwer
0efad12 
Add regression test for 128705

close: rust-lang#128705
@bend-n bend-n mentioned this pull request Nov 23, 2025
Closed
@jhpratt jhpratt mentioned this pull request Nov 23, 2025
Merged
bors added a commit that referenced this pull request Nov 23, 2025
@bors
Auto merge of #149247 - jhpratt:rollup-mq8f5wo, r=jhpratt
d3e1ccd 
Rollup of 3 pull requests

Successful merges:

 - #149179 (Add regression test for 128705)
 - #149197 (validate usage of crate-level doc attributes)
 - #149232 (Add doc aliases "vector" and "list" to `Vec`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2b3b95b into rust-lang:main Nov 24, 2025
11 of 12 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 24, 2025
rust-timer added a commit that referenced this pull request Nov 24, 2025
@rust-timer
Unrolled build for #149179
4f81c50 
Rollup merge of #149179 - reddevilmidzy:test, r=JonathanBrouwer

Add regression test for 128705

close: #128705
@bors
Copy link
Collaborator

bors commented Nov 24, 2025

⌛ Testing commit a4ee7f8 with merge d3e1ccd...

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 24, 2025
@bors
Auto merge of #149247 - jhpratt:rollup-mq8f5wo, r=jhpratt
6b5af2a 
Rollup of 3 pull requests

Successful merges:

 - rust-lang/rust#149179 (Add regression test for 128705)
 - rust-lang/rust#149197 (validate usage of crate-level doc attributes)
 - rust-lang/rust#149232 (Add doc aliases "vector" and "list" to `Vec`)

r? `@ghost`
`@rustbot` modify labels: rollup
@reddevilmidzy reddevilmidzy deleted the test branch November 24, 2025 14:46
@Zalathar
Copy link
Member

Zalathar commented Nov 30, 2025

Bors, this is already merged.

@bors r- retry

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

E0038 emmitted twice

6 participants

@reddevilmidzy @rustbot @JonathanBrouwer @bors @Zalathar @fee1-dead