Skip to content

update git pre-push hook to check for uncommitted changes #149636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Gladdstone wants to merge 1 commit into from
Closed

update git pre-push hook to check for uncommitted changes #149636

Gladdstone wants to merge 1 commit into from

Conversation

@Gladdstone
Copy link

@Gladdstone Gladdstone commented Dec 4, 2025 •
edited by rustbot
Loading

Resolves #149599

Please let me know if there are any phrasing issues.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 4, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jyn514
Copy link
Member

jyn514 commented Dec 4, 2025

please don’t do this. run on the staged changes in a temporary directory instead: #125654

@jyn514
Copy link
Member

jyn514 commented Dec 4, 2025

there’s some prior art in #147084 you could look at.

cc @Kobzol

@jieyouxu jieyouxu mentioned this pull request Dec 4, 2025
Closed
@jieyouxu jieyouxu added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Dec 4, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Dec 4, 2025

See also #125654 (comment)

@jieyouxu
Copy link
Member

jieyouxu commented Dec 6, 2025

@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 6, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 6, 2025
@Kobzol
Copy link
Member

Kobzol commented Dec 6, 2025

Yeah I think that adding this message is probably more annoying than PR CI failing, to be honest.

@Gladdstone
Copy link
Author

Gladdstone commented Dec 7, 2025

It seems that #147084 has been at least partially merged as #148017. Unclear if the rest of this feature is currently in flight, but I'm going to close this PR at least for the time being, as it doesn't seem to be needed.

@Gladdstone Gladdstone closed this Dec 7, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Git pre-push hook doesn't check for uncommitted changes

6 participants

@Gladdstone @rustbot @jyn514 @jieyouxu @Kobzol @Mark-Simulacrum