Explain why &self is common #23788
Merged
Explain why &self is common #23788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -51,7 +51,8 @@ You can think of this first parameter as being the `x` in `x.foo()`. The three | |||
| variants correspond to the three kinds of thing `x` could be: `self` if it's | |||
| just a value on the stack, `&self` if it's a reference, and `&mut self` if it's | |||
| a mutable reference. We should default to using `&self`, as it's the most | |||
| common. Here's an example of all three variants: | |||
| common, as Rustaceans prefer borrowing over taking ownership, and immutable | |||
There was a problem hiding this comment.
Perhaps "immutable borrowing" should be called "shared borrowing"?
|
@alexcrichton updated, what do you think of this? |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23748