Skip to content

Conversation

@DanielJCampbell
Copy link
Contributor

r? @nrc

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you be more explicit about what "local spans" are? And maybe a better name for the field is imported_macro_spans

@DanielJCampbell
Copy link
Contributor Author

Change made

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need the Box here?

@DanielJCampbell
Copy link
Contributor Author

Changes have been made. Hopefully that should be everything (let me know if you're happy with the use of span_bug for checking visit_mac)

@nrc
Copy link
Member

nrc commented Feb 1, 2016

@bors: r+

@bors
Copy link
Collaborator

bors commented Feb 1, 2016

📌 Commit 1d32641 has been approved by nrc

bors added a commit that referenced this pull request Feb 2, 2016
@bors
Copy link
Collaborator

bors commented Feb 2, 2016

⌛ Testing commit 1d32641 with merge a4a249f...

@bors bors merged commit 1d32641 into rust-lang:master Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants