diff --git a/src/librustc_lint/builtin.rs b/src/librustc_lint/builtin.rs index 57ed298809635..c9ec152841b20 100644 --- a/src/librustc_lint/builtin.rs +++ b/src/librustc_lint/builtin.rs @@ -45,6 +45,7 @@ use syntax::ast; use syntax::attr; use syntax::feature_gate::{AttributeGate, AttributeType, Stability, deprecated_attributes}; use syntax_pos::Span; +use syntax::symbol::keywords; use rustc::hir::{self, PatKind}; use rustc::hir::intravisit::FnKind; @@ -605,6 +606,44 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MissingDebugImplementations { } } +declare_lint! { + pub ANONYMOUS_PARAMETERS, + Allow, + "detects anonymous parameters" +} + +/// Checks for use of anonymous parameters (RFC 1685) +#[derive(Clone)] +pub struct AnonymousParameters; + +impl LintPass for AnonymousParameters { + fn get_lints(&self) -> LintArray { + lint_array!(ANONYMOUS_PARAMETERS) + } +} + +impl EarlyLintPass for AnonymousParameters { + fn check_trait_item(&mut self, cx: &EarlyContext, it: &ast::TraitItem) { + match it.node { + ast::TraitItemKind::Method(ref sig, _) => { + for arg in sig.decl.inputs.iter() { + match arg.pat.node { + ast::PatKind::Ident(_, ident, None) => { + if ident.node.name == keywords::Invalid.name() { + cx.span_lint(ANONYMOUS_PARAMETERS, + arg.pat.span, + "use of deprecated anonymous parameter"); + } + } + _ => (), + } + } + }, + _ => (), + } + } +} + declare_lint! { DEPRECATED_ATTR, Warn, diff --git a/src/librustc_lint/lib.rs b/src/librustc_lint/lib.rs index 8d759d89135ac..c1c14cb1fd29e 100644 --- a/src/librustc_lint/lib.rs +++ b/src/librustc_lint/lib.rs @@ -112,6 +112,7 @@ pub fn register_builtins(store: &mut lint::LintStore, sess: Option<&Session>) { add_early_builtin!(sess, UnusedParens, UnusedImportBraces, + AnonymousParameters, ); add_early_builtin_with_new!(sess, @@ -244,6 +245,10 @@ pub fn register_builtins(store: &mut lint::LintStore, sess: Option<&Session>) { id: LintId::of(MISSING_FRAGMENT_SPECIFIER), reference: "issue #40107 ", }, + FutureIncompatibleInfo { + id: LintId::of(ANONYMOUS_PARAMETERS), + reference: "issue #41686 ", + }, ]); // Register renamed and removed lints diff --git a/src/test/compile-fail/anon-params-deprecated.rs b/src/test/compile-fail/anon-params-deprecated.rs new file mode 100644 index 0000000000000..76edae17dc104 --- /dev/null +++ b/src/test/compile-fail/anon-params-deprecated.rs @@ -0,0 +1,25 @@ +// Copyright 2017 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +#![forbid(anonymous_parameters)] +// Test for the anonymous_parameters deprecation lint (RFC 1685) + +trait T { + fn foo(i32); //~ ERROR use of deprecated anonymous parameter + //~| WARNING hard error + + fn bar_with_default_impl(String, String) {} + //~^ ERROR use of deprecated anonymous parameter + //~| WARNING hard error + //~| ERROR use of deprecated anonymous parameter + //~| WARNING hard error +} + +fn main() {}