From 911e476cbee77e4ddd494122c99feb928f3b739b Mon Sep 17 00:00:00 2001 From: est31 Date: Tue, 31 Oct 2017 21:39:32 +0100 Subject: [PATCH 1/2] Tidy: track rustc_const_unstable feature gates as well This is important for the unstable book stub generation. --- src/tools/tidy/src/features.rs | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/src/tools/tidy/src/features.rs b/src/tools/tidy/src/features.rs index a2a264490a141..671798b28e19a 100644 --- a/src/tools/tidy/src/features.rs +++ b/src/tools/tidy/src/features.rs @@ -351,6 +351,26 @@ fn map_lib_features(base_src_path: &Path, } } becoming_feature = None; + if line.contains("rustc_const_unstable(") && line.contains("#[") { + // const fn features are handled specially + let feature_name = match find_attr_val(line, "feature") { + Some(name) => name, + None => err!("malformed stability attribute"), + }; + let feature = Feature { + level: Status::Unstable, + since: "None".to_owned(), + has_gate_test: false, + // Whether there is a common tracking issue + // for these feature gates remains an open question + // https://github.com/rust-lang/rust/issues/24111#issuecomment-340283184 + // But we take 24111 otherwise they will be shown as + // "internal to the compiler" which they are not. + tracking_issue: Some(24111), + }; + mf(Ok((feature_name, feature)), file, i + 1); + continue; + } let level = if line.contains("[unstable(") { Status::Unstable } else if line.contains("[stable(") { From 6a16a7c05b2fc65e28f87f1859323b4be6d5f95f Mon Sep 17 00:00:00 2001 From: est31 Date: Tue, 31 Oct 2017 21:46:05 +0100 Subject: [PATCH 2/2] Also support macro generated atomic types This is kind of a hack but it works... --- src/tools/tidy/src/features.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tools/tidy/src/features.rs b/src/tools/tidy/src/features.rs index 671798b28e19a..9736c03993081 100644 --- a/src/tools/tidy/src/features.rs +++ b/src/tools/tidy/src/features.rs @@ -351,7 +351,7 @@ fn map_lib_features(base_src_path: &Path, } } becoming_feature = None; - if line.contains("rustc_const_unstable(") && line.contains("#[") { + if line.contains("rustc_const_unstable(") { // const fn features are handled specially let feature_name = match find_attr_val(line, "feature") { Some(name) => name,