Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example using &str to trim_start_matches docs #56968

Closed
wants to merge 1 commit into from
Closed

Add example using &str to trim_start_matches docs #56968

wants to merge 1 commit into from

Conversation

estebank
Copy link
Contributor

Fix #56891.

@rust-highfive
Copy link
Collaborator

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 19, 2018
@shepmaster
Copy link
Member

I'm not in favor of adding these, especially not piecemeal, function-by-function. See #54520

@estebank estebank closed this Dec 21, 2018
@shepmaster
Copy link
Member

(to be clear, some other reviewer may be in favor 😉!)

@estebank
Copy link
Contributor Author

True, but you're the reviewer who was assigned :)

I'll defer to @QuietMisdreavus and @GuillaumeGomez judgement as they are in the doc team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shepmaster shepmaster

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebank @rust-highfive @shepmaster