From 66ae3131fc16c76fbad4309a39b3300114dc8141 Mon Sep 17 00:00:00 2001 From: kennytm Date: Sun, 17 Feb 2019 23:19:47 +0800 Subject: [PATCH] publish_toolstate.py: further fix the runtime errors The regex was missing a `,`, causing `relevant_pr_match` to become None and set the PR number to -1 and assigned the new issue to `@`. This causes the 422 error when creating the issue due to invalid assignee and unable to leave the tool-is-broken comment since PR -1 does not exist. The default user names are now also changed to @ghost to prevent the 422 error in case anything goes wrong again. --- src/tools/publish_toolstate.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/tools/publish_toolstate.py b/src/tools/publish_toolstate.py index ef17d6fbd5db3..abcf14d90be15 100755 --- a/src/tools/publish_toolstate.py +++ b/src/tools/publish_toolstate.py @@ -171,7 +171,7 @@ def update_latest( # assume that PR authors are also owners of the repo where the branch lives relevant_pr_match = re.search( - 'Auto merge of #([0-9]+) - ([^:]+):[^,]+ r=([^\s]+)', + r'Auto merge of #([0-9]+) - ([^:]+):[^,]+, r=(\S+)', cur_commit_msg, ) if relevant_pr_match: @@ -182,10 +182,10 @@ def update_latest( pr_reviewer = relevant_pr_match.group(3) else: number = '-1' - relevant_pr_user = '' + relevant_pr_user = 'ghost' relevant_pr_number = '' relevant_pr_url = '' - pr_reviewer = '' + pr_reviewer = 'ghost' message = update_latest( cur_commit,