Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 17 pull requests #64456

Merged
merged 50 commits into from
Sep 14, 2019
Merged

Rollup of 17 pull requests #64456

merged 50 commits into from
Sep 14, 2019

Commits on Aug 24, 2019

  1. Configuration menu
    Copy the full SHA
    33788c2 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2019

  1. Update src/libstd/time.rs

    Co-Authored-By: lzutao <taolzu@gmail.com>
    DevQps and tesuji authored Aug 26, 2019
    Configuration menu
    Copy the full SHA
    1478ef4 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2019

  1. Configuration menu
    Copy the full SHA
    ff63bf8 View commit details
    Browse the repository at this point in the history
  2. Update other doc.

    Value was renamed to Operand in rust-lang@ad2de8b
    ScalarPair to Slice in rust-lang@fe50b4e
    
    Not familiar enough with rustc's source to know if the comment is even still applicable.
    goddessfreya authored Sep 3, 2019
    Configuration menu
    Copy the full SHA
    7589d3a View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2019

  1. Configuration menu
    Copy the full SHA
    b0006df View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2019

  1. Configuration menu
    Copy the full SHA
    36b37e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2019

  1. Add some assertions on obligation type sizes.

    These are types that get memcpy'd a lot.
    nnethercote committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    c1b9a46 View commit details
    Browse the repository at this point in the history
  2. Shrink ObligationCauseCode by boxing MatchExpressionArm.

    The reduction in `memcpy` calls greatly outweighs the cost of the extra
    allocations, for a net performance win.
    nnethercote committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    b972ac8 View commit details
    Browse the repository at this point in the history
  3. Shrink ObligationCauseCode by boxing IfExpression.

    The reduction in `memcpy` calls outweighs the cost of the extra
    allocations, for a net performance win.
    nnethercote committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    2e3b079 View commit details
    Browse the repository at this point in the history
  4. Added some context on SGX. Lists Darwin separately.

    Christian committed Sep 9, 2019
    Configuration menu
    Copy the full SHA
    3dd0e2b View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2019

  1. use randSecure and randABytes

    bpangWR committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    5287885 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2019

  1. Merge pull request rust-lang#20 from Wind-River/rand

    use randSecure and randABytes
    BaoshanPang authored Sep 11, 2019
    Configuration menu
    Copy the full SHA
    83e7976 View commit details
    Browse the repository at this point in the history
  2. Merge pull request rust-lang#21 from rust-lang/master

    Sync with rust-lang/rust master branch
    BaoshanPang authored Sep 11, 2019
    Configuration menu
    Copy the full SHA
    5e8bf87 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b731e11 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a8c5f90 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    223600a View commit details
    Browse the repository at this point in the history
  6. Box DiagnosticBuilder.

    It's a large type -- 176 bytes on 64-bit. And it's passed around and
    returned from a lot of functions, including within PResult.
    
    This commit boxes it, which reduces memory traffic. In particular,
    `PResult` shrinks to 16 bytes in the best case; this reduces instruction
    counts by up to 2% on various workloads.
    nnethercote committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    2fcd870 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2019

  1. Merge pull request rust-lang#22 from Wind-River/master_002

    declare EnvKey before use to fix build error
    BaoshanPang authored Sep 12, 2019
    Configuration menu
    Copy the full SHA
    08fa803 View commit details
    Browse the repository at this point in the history
  2. Trim rustc-workspace-hack

    mati865 committed Sep 12, 2019
    Configuration menu
    Copy the full SHA
    612c394 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e9214a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2019

  1. Inline mark_neighbours_as_waiting_from.

    This function is very hot, doesn't get inlined because it's recursive,
    and the function calls are significant.
    
    This commit splits it into inlined and uninlined variants, and uses the
    inlined variant for the hot call site. This wins several percent on a
    few benchmarks.
    nnethercote committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    a2261ad View commit details
    Browse the repository at this point in the history
  2. typo fix

    Guanqun Lu committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    a47a5c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bd25507 View commit details
    Browse the repository at this point in the history
  4. Add self to .mailmap

    ollie27 committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    69112a2 View commit details
    Browse the repository at this point in the history
  5. Update src/libstd/time.rs

    Co-Authored-By: Robin Kruppe <robin.kruppe@gmail.com>
    DevQps and Robin Kruppe authored Sep 13, 2019
    Configuration menu
    Copy the full SHA
    b3b6713 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7437f77 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c529294 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bdad2c5 View commit details
    Browse the repository at this point in the history
  9. fix rust-lang#64430

    12101111 committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    57e8287 View commit details
    Browse the repository at this point in the history
  10. add ui test for rust-lang#64430

    12101111 committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    b98a844 View commit details
    Browse the repository at this point in the history
  11. add trailing newline

    12101111 committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    e484f21 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2019

  1. Update value.rs

    goddessfreya authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    094af97 View commit details
    Browse the repository at this point in the history
  2. Update src/liballoc/raw_vec.rs

    Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
    alexreg and Centril authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    58a26c8 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#63846 - DevQps:32626-document-time-system-c…

    …alls, r=rkruppe
    
    Added table containing the system calls used by Instant and SystemTime.
    
    # Description
    See rust-lang#32626 for a discussion on documenting system calls used by Instant and SystemTime.
    
    ## Changes
    - Added a table containing the system calls used by each platform.
    
    EDIT: If I can format this table better (due to the large links) please let me know.
    I'd also be happy to learn a quick command to generate the docs on my host machine! Currently I am using: `python x.py doc --stage 0 src/libstd` but that gives me some `unrecognized intrinsic` errors. Advice is always welcome :)
    
    closes rust-lang#32626
    Centril authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    baaaea3 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#64116 - ZeGentzy:patch-1, r=oli-obk

    Fix minor typo in docs.
    
    This comment is prolly refering to the comment in [const_eval_raw_provider](https://github.com/rust-lang/rust/pull/64116/files#diff-e0b58bb6712edaa8595ad7237542c958R616), not itself.
    Centril authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    45baedb View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#64203 - alexreg:rush-pr-2, r=centril

    A few cosmetic improvements to code & comments in liballoc and libcore
    
    Factored out from hacking on rustc for work on the REPL.
    
    r? @Centril
    Centril authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    afc5291 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#64302 - nnethercote:shrink-ObligationCauseC…

    …ode, r=zackmdavis
    
    Shrink `ObligationCauseCode`
    
    These commits reduce the size of `ObligationCauseCode` from 56 bytes to 32 bytes on 64-bit. This reduces instruction counts on various benchmarks by up to 1%, due to less `memcpy`ing.
    Centril authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    1054158 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#64372 - Wind-River:master, r=alexcrichton

    use randSecure and randABytes
    
    r? @alexcrichton
    
    cc @n-salim
    Centril authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    1e2a970 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#64374 - nnethercote:box-DiagnosticBuilder, …

    …r=zackmdavis
    
    Box `DiagnosticBuilder`.
    
    It's a large type -- 176 bytes on 64-bit. And it's passed around and
    returned from a lot of functions, including within `PResult`.
    
    This commit boxes it, which reduces memory traffic. In particular,
    `PResult` shrinks to 16 bytes in the best case; this reduces instruction
    counts by up to 2% on various workloads. The commit touches a lot of
    lines but it's almost all trivial plumbing changes.
    Centril authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    af33a1d View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#64375 - kornelski:vecdrop, r=rkruppe

    Fast path for vec.clear/truncate
    
    For trivial types like `u8`, `vec.truncate()`/`vec.clear()` relies on the optimizer to remove the loop. This means more work in debug builds, and more work for the optimizer.
    
    Avoiding this busywork is exactly what `mem::needs_drop::<T>()` is for.
    Centril authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    c6c2acd View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#64378 - Rosto75:master, r=jonas-schievink

    Fix inconsistent link formatting.
    Centril authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    ae9d417 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#64384 - mati865:tools_hack, r=alexcrichton

    Trim rustc-workspace-hack
    
    Those dependencies seem no longer necessary.
    `./x.py test` and `x86_64-gnu-tools` container passed locally so I think this won't hurt.
    Centril authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    f7dd5d0 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#64393 - Wind-River:master_002_envKey, r=ale…

    …xcrichton
    
     declare EnvKey before use to fix build error
    
    r? @alexcrichton
    Centril authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    f669872 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#64420 - nnethercote:inline-mark_neighbours_…

    …as_waiting_from, r=Mark-Simulacrum
    
    Inline `mark_neighbours_as_waiting_from`.
    
    This function is very hot, doesn't get inlined because it's recursive,
    and the function calls are significant.
    
    This commit splits it into inlined and uninlined variants, and uses the
    inlined variant for the hot call site. This wins several percent on a
    few benchmarks.
    
    r? @nikomatsakis
    Centril authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    5e44c5f View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#64422 - ollie27:error_index_generator_strin…

    …gify, r=Mark-Simulacrum
    
    Remove raw string literal quotes from error index descriptions
    
    The error index has unnecessary `r##"` and `"##` around the descriptions from rust-lang#63721. Removing the `stringify` call removes them.
    
    r? @Mark-Simulacrum
    Centril authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    181d129 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#64423 - ollie27:mailmap, r=Mark-Simulacrum

    Add self to .mailmap
    Centril authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    70787c7 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    4398eb7 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#64431 - pnkfelix:issue-63479-fnptr-is-struc…

    …tural-match, r=varkor
    
    fn ptr is structural match
    
    Make fn ptr always structural match, regardless of whether the formal parameter types or return type are.
    
    Fix rust-lang#63479.
    Centril authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    5160e4b View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#64435 - eddyb:arguments-against-arg, r=rkruppe

    codegen: use "_N" (like for other locals) instead of "argN", for argument names.
    
    Based on rust-lang#64408 (second commit is new), fixing something I mentioned in rust-lang#64408 (which turned to be an immediate blocker for unifying relevant codepaths).
    
    Closes rust-lang#64408 (by containing it).
    
    r? @rkruppe
    Centril authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    bf1253b View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#64439 - 12101111:fix-owned-box, r=Centril

    fix rust-lang#64430, confusing `owned_box` error message in no_std build
    
    Fixes rust-lang#64430
    Centril authored Sep 14, 2019
    Configuration menu
    Copy the full SHA
    1c7959b View commit details
    Browse the repository at this point in the history