From 2b42a2b541e04164428e83a4adfc4c120a482f82 Mon Sep 17 00:00:00 2001
From: Mark Rousskov <mark.simulacrum@gmail.com>
Date: Wed, 13 May 2020 11:32:43 -0400
Subject: [PATCH] Forbid stage arguments to check
Users generally expect that check builds are fast, and that's only true in stage
0 (stages beyond that need us to build a compiler, which is slow).
---
src/bootstrap/flags.rs | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/src/bootstrap/flags.rs b/src/bootstrap/flags.rs
index fb380af0a47e7..646b9e05d99c3 100644
--- a/src/bootstrap/flags.rs
+++ b/src/bootstrap/flags.rs
@@ -503,6 +503,20 @@ Arguments:
}
};
+ if let Subcommand::Check { .. } = &cmd {
+ if matches.opt_str("stage").is_some() {
+ println!("{}", "--stage not supported for x.py check, always treated as stage 0");
+ process::exit(1);
+ }
+ if matches.opt_str("keep-stage").is_some() {
+ println!(
+ "{}",
+ "--keep-stage not supported for x.py check, only one stage available"
+ );
+ process::exit(1);
+ }
+ }
+
Flags {
verbose: matches.opt_count("verbose"),
stage: matches.opt_str("stage").map(|j| j.parse().expect("`stage` should be a number")),