Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 7 pull requests #78371

Closed
wants to merge 31 commits into from
Closed

Rollup of 7 pull requests #78371

wants to merge 31 commits into from

Commits on Oct 22, 2020

  1. Check which places are dead 

    Fixes rust-lang#78192
    @simonvandel
    simonvandel committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    57d01a9 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Capture output from threads spawned in tests 

    Fixes rust-lang#42474.
    @tmandry @SergioBenitez
    tmandry authored and SergioBenitez committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    d0d0e78 View commit details
    Browse the repository at this point in the history

  2. Only load LOCAL_STREAMS if they are being used

    @SergioBenitez
    SergioBenitez committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    db15596 View commit details
    Browse the repository at this point in the history

  3. Tweak "use .await" suggestion

    @estebank
    estebank committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    86df903 View commit details
    Browse the repository at this point in the history

  4. Suggest semicolon removal on prior match arm

    @estebank
    estebank committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    a4ee3ca View commit details
    Browse the repository at this point in the history

  5. Account for possible boxable impl Future in semicolon removal sugge… 

    …stions
    @estebank
    estebank committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    671d7c4 View commit details
    Browse the repository at this point in the history

  6. Review comments: use newtype instead of bool

    @estebank
    estebank committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    62ba365 View commit details
    Browse the repository at this point in the history

  7. Silence unnecessary await foo? knock-down error

    @estebank
    estebank committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    3a0227b View commit details
    Browse the repository at this point in the history

  8. Add test case for different impl Futures

    @estebank
    estebank committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    1829b4a View commit details
    Browse the repository at this point in the history

  9. Add more .await suggestions on E0308

    @estebank
    estebank committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    c548511 View commit details
    Browse the repository at this point in the history

  10. Suggest semicolon removal and boxing when appropriate

    @estebank
    estebank committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    f5d7443 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2020

  1. ensure that statics are inhabited

    @RalfJung
    RalfJung committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    1333206 View commit details
    Browse the repository at this point in the history

  2. Miri engine validity check: simplify code with 'matches!' 

    and improve a comment a bit
    @RalfJung
    RalfJung committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    2585124 View commit details
    Browse the repository at this point in the history

  3. Miri engine interning: improve comments, and entirely skip ZST

    @RalfJung
    RalfJung committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    d8ec83f View commit details
    Browse the repository at this point in the history

  4. ensure we intern all promoteds as InternKind::Promoted

    @RalfJung
    RalfJung committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    778ddff View commit details
    Browse the repository at this point in the history

  5. fix typo 

    Co-authored-by: BlackHoleFox <blackholefoxdev@gmail.com>
    @RalfJung @BlackHoleFox
    RalfJung and BlackHoleFox authored Oct 24, 2020
    Configuration menu
    Copy the full SHA
    5d62492 View commit details
    Browse the repository at this point in the history

  6. move UnsafeCell-in-const check from interning to validation

    @RalfJung
    RalfJung committed Oct 24, 2020
    Configuration menu
    Copy the full SHA
    849c929 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2020

  1. Do not try to report on closures to avoid ICE

    @JohnTitor
    JohnTitor committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    7b4c397 View commit details
    Browse the repository at this point in the history

  2. Test with NLL explicitly

    @JohnTitor
    JohnTitor committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    4ec396e View commit details
    Browse the repository at this point in the history

  3. Make some functions private that don't have to be public

    @jyn514
    jyn514 committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    e218380 View commit details
    Browse the repository at this point in the history

  4. move &mut-in-const check from interning to validation

    @RalfJung
    RalfJung committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    341170d View commit details
    Browse the repository at this point in the history

  5. interning cleanup: we no longer need to distinguish Const and ConstIn… 

    …ner; we no longer need the ignore_interior_mut_in_const hack
    @RalfJung
    RalfJung committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    7c7b90d View commit details
    Browse the repository at this point in the history

  6. explain why interning is not as trivial as it might seem

    @RalfJung
    RalfJung committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    db01d97 View commit details
    Browse the repository at this point in the history

  7. also test non-extern uninhabited statics

    @RalfJung
    RalfJung committed Oct 25, 2020
    Configuration menu
    Copy the full SHA
    3bd5cc9 View commit details
    Browse the repository at this point in the history

  8. Rollup merge of rust-lang#78214 - estebank:match-semicolon, r=oli-obk 

    Tweak match arm semicolon removal suggestion to account for futures

* Tweak and extend "use `.await`" suggestions
* Suggest removal of semicolon on prior match arm
* Account for `impl Future` when suggesting semicolon removal
* Silence some errors when encountering `await foo()?` as can't be certain what the intent was

*Thanks to https://twitter.com/a_hoverbear/status/1318960787105353728 for pointing this out!*
    @Dylan-DPC
    Dylan-DPC authored Oct 25, 2020
    Configuration menu
    Copy the full SHA
    b9e7982 View commit details
    Browse the repository at this point in the history

  9. Rollup merge of rust-lang#78227 - SergioBenitez:test-stdout-threading… 

    …, r=m-ou-se

Capture output from threads spawned in tests

This is revival of rust-lang#75172.

Original text:
> Fixes rust-lang#42474.
>
> r? `@dtolnay` since you expressed interest in this, but feel free to redirect if you aren't the right person anymore.

---

Closes rust-lang#75172.
    @Dylan-DPC
    Dylan-DPC authored Oct 25, 2020
    Configuration menu
    Copy the full SHA
    117ce17 View commit details
    Browse the repository at this point in the history

  10. Rollup merge of rust-lang#78247 - simonvandel:fix-78192, r=oli-obk 

    Fix rust-lang#78192

Check which places are marked dead.

Fixes rust-lang#78192
    @Dylan-DPC
    Dylan-DPC authored Oct 25, 2020
    Configuration menu
    Copy the full SHA
    9fe1de1 View commit details
    Browse the repository at this point in the history

  11. Rollup merge of rust-lang#78268 - JohnTitor:issue-78262, r=estebank 

    Do not try to report on closures to avoid ICE

Fixes rust-lang#78262
    @Dylan-DPC
    Dylan-DPC authored Oct 25, 2020
    Configuration menu
    Copy the full SHA
    93b4abf View commit details
    Browse the repository at this point in the history

  12. Rollup merge of rust-lang#78324 - RalfJung:uninhabited-statics, r=oli… 

    …-obk

ensure that statics are inhabited

Fixes rust-lang#74840

r? @oli-obk
    @Dylan-DPC
    Dylan-DPC authored Oct 25, 2020
    Configuration menu
    Copy the full SHA
    da10bd8 View commit details
    Browse the repository at this point in the history

  13. Rollup merge of rust-lang#78348 - jyn514:pub-crate, r=GuillaumeGomez 

    Make some functions private that don't have to be public

r? @GuillaumeGomez
    @Dylan-DPC
    Dylan-DPC authored Oct 25, 2020
    Configuration menu
    Copy the full SHA
    9c08ed0 View commit details
    Browse the repository at this point in the history

  14. Rollup merge of rust-lang#78351 - RalfJung:validity-unsafe-cell, r=ol… 

    …i-obk

Move "mutable thing in const" check from interning to validity

This moves the check for mutable things (such as `UnsafeCell` or `&mut`) in a`const` from interning to validity. That means we can give more targeted error messages (pointing out *where* the problem lies), and we can simplify interning a bit.

Also fix the interning mode used for promoteds in statics.

r? @oli-obk
    @Dylan-DPC
    Dylan-DPC authored Oct 25, 2020
    Configuration menu
    Copy the full SHA
    04fe7fa View commit details
    Browse the repository at this point in the history