-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #78661
Rollup of 5 pull requests #78661
Commits on Oct 31, 2020
-
Clarify handling of final line ending in str::lines()
I found the description as it stands a bit confusing. I've added a bit more explanation to make it clear that a trailing line ending does not produce a final empty line.
Configuration menu - View commit details
-
Copy full SHA for 47279b3 - Browse repository at this point
Copy the full SHA 47279b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b63e9b - Browse repository at this point
Copy the full SHA 6b63e9bView commit details
Commits on Nov 1, 2020
-
Trivial fixes to bitwise operator documentation
Added fixes to documentation of `BitAnd`, `BitOr`, `BitXor` and `BitAndAssign`, where the documentation for implementation on `Vector<bool>` was using logical operators in place of the bitwise operators. r? @steveklabnik cc rust-lang#78619
Configuration menu - View commit details
-
Copy full SHA for 66d68cd - Browse repository at this point
Copy the full SHA 66d68cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c88bcc - Browse repository at this point
Copy the full SHA 7c88bccView commit details -
Configuration menu - View commit details
-
Copy full SHA for d422e24 - Browse repository at this point
Copy the full SHA d422e24View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2d7b3a - Browse repository at this point
Copy the full SHA b2d7b3aView commit details -
Point out that total_cmp is no strict superset of partial comparison
Partial comparison and total_cmp are not equal. This helps preventing the mistake of creating float wrappers that base their Ord impl on total_cmp and their PartialOrd impl on the PartialOrd impl of the float type. PartialOrd and Ord are required to agree with each other.
Configuration menu - View commit details
-
Copy full SHA for a79059d - Browse repository at this point
Copy the full SHA a79059dView commit details -
Add fetch_update methods to AtomicBool and AtomicPtr
These methods were stabilized for the integer atomics in rust-lang#71843, but the methods were not added for the non-integer atomics `AtomicBool` and `AtomicPtr`.
Configuration menu - View commit details
-
Copy full SHA for 00f32e6 - Browse repository at this point
Copy the full SHA 00f32e6View commit details
Commits on Nov 2, 2020
-
Rollup merge of rust-lang#78606 - autarch:patch-1, r=m-ou-se
Clarify handling of final line ending in str::lines() I found the description as it stands a bit confusing. I've added a bit more explanation to make it clear that a trailing line ending does not produce a final empty line.
Configuration menu - View commit details
-
Copy full SHA for 0fdb371 - Browse repository at this point
Copy the full SHA 0fdb371View commit details -
Rollup merge of rust-lang#78610 - petrochenkov:nostriptok, r=Aaron1011
Do not remove tokens before AST json serialization `TokenStripper` is error-prone and introduces one more use of `MutVisitor`. It's much simpler to treat serialization as just one more place that wants lazy token stream to turn into a real token stream. Also, no code is better than more code, in general. r? @Aaron1011 (I also merged tests for `TokenStripper` ICEs into one.)
Configuration menu - View commit details
-
Copy full SHA for 61305d5 - Browse repository at this point
Copy the full SHA 61305d5View commit details -
Rollup merge of rust-lang#78620 - gabhijit:bitops_doc_fix, r=m-ou-se
Trivial fixes to bitwise operator documentation Added fixes to documentation of `BitAnd`, `BitOr`, `BitXor` and `BitAndAssign`, where the documentation for implementation on `Vector<bool>` was using logical operators in place of the bitwise operators. r? @steveklabnik Closes rust-lang#78619
Configuration menu - View commit details
-
Copy full SHA for 7baf48f - Browse repository at this point
Copy the full SHA 7baf48fView commit details -
Rollup merge of rust-lang#78627 - est31:total_cmp_no_superset, r=m-ou-se
Point out that total_cmp is no strict superset of partial comparison Partial comparison and total_cmp are not equal. This helps preventing the mistake of creating float wrappers that base their Ord impl on total_cmp and their PartialOrd impl on the PartialOrd impl of the float type. PartialOrd and Ord [are required to agree with each other](https://doc.rust-lang.org/std/cmp/trait.Ord.html#how-can-i-implement-ord).
Configuration menu - View commit details
-
Copy full SHA for fb7948e - Browse repository at this point
Copy the full SHA fb7948eView commit details -
Rollup merge of rust-lang#78637 - mystor:atomic_ptr_bool, r=m-ou-se
Add fetch_update methods to AtomicBool and AtomicPtr These methods were stabilized for the integer atomics in rust-lang#71843, but the methods were not added for the non-integer atomics `AtomicBool` and `AtomicPtr`.
Configuration menu - View commit details
-
Copy full SHA for 50d7716 - Browse repository at this point
Copy the full SHA 50d7716View commit details