Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point at capture points for non-'static reference crossing a yield point #89734

Merged
merged 14 commits into from
Dec 11, 2021

Commits on Dec 10, 2021

  1. Point at capture points for non-'static reference crossing a `yield…

    …` point
    
    ```
    error[E0759]: `self` has an anonymous lifetime `'_` but it needs to satisfy a `'static` lifetime requirement
      --> $DIR/issue-72312.rs:10:24
       |
    LL |     pub async fn start(&self) {
       |                        ^^^^^ this data with an anonymous lifetime `'_`...
    ...
    LL |         require_static(async move {
       |         -------------- ...is required to live as long as `'static` here...
    LL |             &self;
       |             ----- ...and is captured here
       |
    note: `'static` lifetime requirement introduced by this trait bound
      --> $DIR/issue-72312.rs:2:22
       |
    LL | fn require_static<T: 'static>(val: T) -> T {
       |                      ^^^^^^^
    
    error: aborting due to previous error
    
    For more information about this error, try `rustc --explain E0759`.
    ```
    
    Fix rust-lang#72312.
    estebank committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    d10fe26 View commit details
    Browse the repository at this point in the history
  2. Clean up visual output logic

    estebank committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    dd81e98 View commit details
    Browse the repository at this point in the history
  3. review comments

    * take diagnostic logic out of happy-path
    * sort/dedup once
    * add more comments
    estebank committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    ab45ab8 View commit details
    Browse the repository at this point in the history
  4. Add filtering based on involved required lifetime

    More accurate filtering still needed.
    estebank committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    09dbf37 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ee0fd10 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    10a74ac View commit details
    Browse the repository at this point in the history
  7. Update nll test

    estebank committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    0ee723e View commit details
    Browse the repository at this point in the history
  8. rebase and update nll test

    estebank committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    ff13ad7 View commit details
    Browse the repository at this point in the history
  9. Tweak wording

    estebank committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    83ce1aa View commit details
    Browse the repository at this point in the history
  10. Review comments

    estebank committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    9cc7bd7 View commit details
    Browse the repository at this point in the history
  11. Remove field from ErrorValue

    estebank committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    d33fa13 View commit details
    Browse the repository at this point in the history
  12. review comment

    estebank committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    da5b0cc View commit details
    Browse the repository at this point in the history
  13. fix tests after rebase

    estebank committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    40f161a View commit details
    Browse the repository at this point in the history
  14. fmt

    estebank committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    d2d9eb3 View commit details
    Browse the repository at this point in the history