From c6f362a7c53c0f824e96eb8039baaa52dc4b2db0 Mon Sep 17 00:00:00 2001 From: Josh Stone Date: Tue, 28 Jun 2022 12:28:01 -0700 Subject: [PATCH 1/2] Let rust-analyzer ship on stable, non-preview --- src/bootstrap/dist.rs | 6 ------ src/tools/build-manifest/src/main.rs | 3 ++- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/bootstrap/dist.rs b/src/bootstrap/dist.rs index 8182d2bf8fb3b..74ec9cab5ca97 100644 --- a/src/bootstrap/dist.rs +++ b/src/bootstrap/dist.rs @@ -1044,12 +1044,6 @@ impl Step for RustAnalyzer { } fn run(self, builder: &Builder<'_>) -> Option { - // This prevents rust-analyzer from being built for "dist" or "install" - // on the stable/beta channels. It is a nightly-only tool and should - // not be included. - if !builder.build.unstable_features() { - return None; - } let compiler = self.compiler; let target = self.target; diff --git a/src/tools/build-manifest/src/main.rs b/src/tools/build-manifest/src/main.rs index 6338e467055cd..efe3f2b618be3 100644 --- a/src/tools/build-manifest/src/main.rs +++ b/src/tools/build-manifest/src/main.rs @@ -184,7 +184,7 @@ static PKG_INSTALLERS: &[&str] = &["x86_64-apple-darwin", "aarch64-apple-darwin" static MINGW: &[&str] = &["i686-pc-windows-gnu", "x86_64-pc-windows-gnu"]; -static NIGHTLY_ONLY_COMPONENTS: &[&str] = &["miri-preview", "rust-analyzer-preview"]; +static NIGHTLY_ONLY_COMPONENTS: &[&str] = &["miri-preview"]; macro_rules! t { ($e:expr) => { @@ -403,6 +403,7 @@ impl Builder { rename("rustfmt", "rustfmt-preview"); rename("clippy", "clippy-preview"); rename("miri", "miri-preview"); + rename("rust-analyzer", "rust-analyzer-preview"); } fn rust_package(&mut self, manifest: &Manifest) -> Package { From c29e584a997083b61a75b0a4e6336cc5f222a354 Mon Sep 17 00:00:00 2001 From: Josh Stone Date: Thu, 30 Jun 2022 10:07:48 -0700 Subject: [PATCH 2/2] Flip RustAnalyzer to stable=true --- src/bootstrap/tool.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bootstrap/tool.rs b/src/bootstrap/tool.rs index 905fa431d29d1..5be6841e988ae 100644 --- a/src/bootstrap/tool.rs +++ b/src/bootstrap/tool.rs @@ -780,7 +780,7 @@ tool_extended!((self, builder), // and this is close enough for now. RustDemangler, rust_demangler, "src/tools/rust-demangler", "rust-demangler", stable=false, in_tree=true, tool_std=true, {}; Rustfmt, rustfmt, "src/tools/rustfmt", "rustfmt", stable=true, in_tree=true, {}; - RustAnalyzer, rust_analyzer, "src/tools/rust-analyzer/crates/rust-analyzer", "rust-analyzer", stable=false, submodule="rust-analyzer", {}; + RustAnalyzer, rust_analyzer, "src/tools/rust-analyzer/crates/rust-analyzer", "rust-analyzer", stable=true, submodule="rust-analyzer", {}; ); impl<'a> Builder<'a> {