From c349dec0839035001c96678bbc7c3cc9b5cb6cd6 Mon Sep 17 00:00:00 2001 From: Santiago Pastorino Date: Thu, 11 Mar 2021 15:03:19 -0300 Subject: [PATCH 01/13] Remove dead link --- src/compiler-team.md | 1 - 1 file changed, 1 deletion(-) diff --git a/src/compiler-team.md b/src/compiler-team.md index ebb8cbc16..0b6e292f8 100644 --- a/src/compiler-team.md +++ b/src/compiler-team.md @@ -53,7 +53,6 @@ complicated). The meeting is held over a "chat medium", currently on [zulip]. -[etherpad]: https://public.etherpad-mozilla.org/p/rust-compiler-meeting [procedure]: ./bug-fix-procedure.md [zulip]: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler [zulip-help]: https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp From c5fe3d3cb85689457b301583fc50057da764d434 Mon Sep 17 00:00:00 2001 From: Santiago Pastorino Date: Thu, 11 Mar 2021 15:04:09 -0300 Subject: [PATCH 02/13] Make general text a bit better --- src/compiler-team.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler-team.md b/src/compiler-team.md index 0b6e292f8..fa5cb9094 100644 --- a/src/compiler-team.md +++ b/src/compiler-team.md @@ -30,7 +30,8 @@ who are experts on each one. ## Rust compiler meeting The compiler team has a weekly meeting where we do triage and try to -generally stay on top of new bugs, regressions, and other things. +generally stay on top of new bugs, regressions, and discuss important +things in general. They are held on [Zulip][zulip]. It works roughly as follows: - **Review P-high bugs:** P-high bugs are those that are sufficiently From ef9bd51fb8e981459b9ab9be5ebdcf1120577985 Mon Sep 17 00:00:00 2001 From: Santiago Pastorino Date: Thu, 11 Mar 2021 15:04:38 -0300 Subject: [PATCH 03/13] Fix Zulip link --- src/compiler-team.md | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/compiler-team.md b/src/compiler-team.md index fa5cb9094..a96f5f6d6 100644 --- a/src/compiler-team.md +++ b/src/compiler-team.md @@ -32,7 +32,7 @@ who are experts on each one. The compiler team has a weekly meeting where we do triage and try to generally stay on top of new bugs, regressions, and discuss important things in general. -They are held on [Zulip][zulip]. It works roughly as follows: +They are held on [Zulip][zulip-meetings]. It works roughly as follows: - **Review P-high bugs:** P-high bugs are those that are sufficiently important for us to actively track progress. P-high bugs should @@ -55,7 +55,6 @@ complicated). The meeting is held over a "chat medium", currently on [zulip]. [procedure]: ./bug-fix-procedure.md -[zulip]: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler [zulip-help]: https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp [zulip-meetings]: https://rust-lang.zulipchat.com/#narrow/stream/238009-t-compiler.2Fmeetings From aa56c7ed1cc17ceafc69ebecdbfc721090bf50bf Mon Sep 17 00:00:00 2001 From: Santiago Pastorino Date: Thu, 11 Mar 2021 15:18:00 -0300 Subject: [PATCH 04/13] Improve description of what the compiler meeting is about --- src/compiler-team.md | 33 +++++++++++++++++++++------------ 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/src/compiler-team.md b/src/compiler-team.md index a96f5f6d6..67cedc4c6 100644 --- a/src/compiler-team.md +++ b/src/compiler-team.md @@ -34,19 +34,28 @@ generally stay on top of new bugs, regressions, and discuss important things in general. They are held on [Zulip][zulip-meetings]. It works roughly as follows: -- **Review P-high bugs:** P-high bugs are those that are sufficiently - important for us to actively track progress. P-high bugs should - ideally always have an assignee. -- **Look over new regressions:** we then look for new cases where the - compiler broke previously working code in the wild. Regressions are - almost always marked as P-high; the major exception would be bug - fixes (though even there we often [aim to give warnings first][procedure]). -- **Check I-nominated issues:** These are issues where feedback from +- **Announcements, MCPs/FCPs and WG-check-ins:** we share some + announcements with the rest of the team about important things we want + everyone to be aware. We also share the status of MCPs and FCPs and we + use the opportunity to have a couple of WGs giving us an update about + their work. +- **Check for beta and stable nominations:** These are nominations of things to + backport to beta and stable respectively. + We then look for new cases where the compiler broke previously working + code in the wild. Regressions are important issues to fix, so it's + likely that they are tagged as P-critical or P-high; the major + exception would be bug fixes (though even there we often [aim to give + warnings first][procedure]). +- **Review P-critical/P-high bugs:** P-critical and P-high bugs are + those that are sufficiently important for us to actively track + progress. P-critical and P-high bugs should ideally always have an + assignee. +- **Check S-waiting-on-team and I-nominated issues:** These are issues where feedback from the team is desired. -- **Check for beta nominations:** These are nominations of things to - backport to beta. -- **Possibly WG checking:** A WG may give an update at this point, if there is - time. +- **Look over the performance logs:** we check for PRs that made the + performance better in some sense and the ones that made it worser + and try to decide if it's worth reverting some regression or if it's + more work to be done to make things better. The meeting currently takes place on Thursdays at 10am Boston time (UTC-4 typically, but daylight savings time sometimes makes things From fae3064d40499a9434df8956920defbc43db81b2 Mon Sep 17 00:00:00 2001 From: Santiago Pastorino Date: Fri, 12 Mar 2021 17:43:12 -0300 Subject: [PATCH 05/13] Update src/compiler-team.md Co-authored-by: Camelid --- src/compiler-team.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler-team.md b/src/compiler-team.md index 67cedc4c6..356c06e54 100644 --- a/src/compiler-team.md +++ b/src/compiler-team.md @@ -34,7 +34,7 @@ generally stay on top of new bugs, regressions, and discuss important things in general. They are held on [Zulip][zulip-meetings]. It works roughly as follows: -- **Announcements, MCPs/FCPs and WG-check-ins:** we share some +- **Announcements, MCPs/FCPs and WG-check-ins:** We share some announcements with the rest of the team about important things we want everyone to be aware. We also share the status of MCPs and FCPs and we use the opportunity to have a couple of WGs giving us an update about From c5a0828e3cd6b1e64550399993fd9ddfd4622c04 Mon Sep 17 00:00:00 2001 From: Santiago Pastorino Date: Fri, 12 Mar 2021 17:43:19 -0300 Subject: [PATCH 06/13] Update src/compiler-team.md Co-authored-by: Camelid --- src/compiler-team.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler-team.md b/src/compiler-team.md index 356c06e54..16a20e2fb 100644 --- a/src/compiler-team.md +++ b/src/compiler-team.md @@ -46,7 +46,7 @@ They are held on [Zulip][zulip-meetings]. It works roughly as follows: likely that they are tagged as P-critical or P-high; the major exception would be bug fixes (though even there we often [aim to give warnings first][procedure]). -- **Review P-critical/P-high bugs:** P-critical and P-high bugs are +- **Review P-critical and P-high bugs:** P-critical and P-high bugs are those that are sufficiently important for us to actively track progress. P-critical and P-high bugs should ideally always have an assignee. From 45f25c98ec6489cb5e776f8cfde4ca8a01e9292b Mon Sep 17 00:00:00 2001 From: Santiago Pastorino Date: Fri, 12 Mar 2021 17:43:26 -0300 Subject: [PATCH 07/13] Update src/compiler-team.md Co-authored-by: Camelid --- src/compiler-team.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler-team.md b/src/compiler-team.md index 16a20e2fb..dab0d1e33 100644 --- a/src/compiler-team.md +++ b/src/compiler-team.md @@ -52,7 +52,7 @@ They are held on [Zulip][zulip-meetings]. It works roughly as follows: assignee. - **Check S-waiting-on-team and I-nominated issues:** These are issues where feedback from the team is desired. -- **Look over the performance logs:** we check for PRs that made the +- **Look over the performance logs:** We check for PRs that made the performance better in some sense and the ones that made it worser and try to decide if it's worth reverting some regression or if it's more work to be done to make things better. From 2f34b9001b94f444be221f717cfcbc0c8a1ac079 Mon Sep 17 00:00:00 2001 From: Santiago Pastorino Date: Sun, 14 Mar 2021 10:03:17 -0300 Subject: [PATCH 08/13] Update src/compiler-team.md Co-authored-by: Camelid --- src/compiler-team.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler-team.md b/src/compiler-team.md index dab0d1e33..df5e1f8b7 100644 --- a/src/compiler-team.md +++ b/src/compiler-team.md @@ -34,7 +34,7 @@ generally stay on top of new bugs, regressions, and discuss important things in general. They are held on [Zulip][zulip-meetings]. It works roughly as follows: -- **Announcements, MCPs/FCPs and WG-check-ins:** We share some +- **Announcements, MCPs/FCPs, and WG-check-ins:** We share some announcements with the rest of the team about important things we want everyone to be aware. We also share the status of MCPs and FCPs and we use the opportunity to have a couple of WGs giving us an update about From d601d80af63166b64ada520a24382ca34d4a66dc Mon Sep 17 00:00:00 2001 From: Santiago Pastorino Date: Wed, 17 Mar 2021 16:43:04 -0300 Subject: [PATCH 09/13] Update src/compiler-team.md Co-authored-by: Ryan Levick --- src/compiler-team.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/compiler-team.md b/src/compiler-team.md index df5e1f8b7..af6ed61ec 100644 --- a/src/compiler-team.md +++ b/src/compiler-team.md @@ -52,10 +52,9 @@ They are held on [Zulip][zulip-meetings]. It works roughly as follows: assignee. - **Check S-waiting-on-team and I-nominated issues:** These are issues where feedback from the team is desired. -- **Look over the performance logs:** We check for PRs that made the - performance better in some sense and the ones that made it worser - and try to decide if it's worth reverting some regression or if it's - more work to be done to make things better. +- **Look over the performance triage report:** We check for PRs that made the + performance worse and try to decide if it's worth reverting the performance regression or if + the regression can be addressed in a future PR. The meeting currently takes place on Thursdays at 10am Boston time (UTC-4 typically, but daylight savings time sometimes makes things From e94b6f690045808bd6b5004a461bbb85083f8f29 Mon Sep 17 00:00:00 2001 From: Santiago Pastorino Date: Thu, 18 Mar 2021 20:59:32 -0300 Subject: [PATCH 10/13] Update src/compiler-team.md Co-authored-by: Yuki Okushi --- src/compiler-team.md | 1 - 1 file changed, 1 deletion(-) diff --git a/src/compiler-team.md b/src/compiler-team.md index af6ed61ec..afaefe42f 100644 --- a/src/compiler-team.md +++ b/src/compiler-team.md @@ -60,7 +60,6 @@ The meeting currently takes place on Thursdays at 10am Boston time (UTC-4 typically, but daylight savings time sometimes makes things complicated). -The meeting is held over a "chat medium", currently on [zulip]. [procedure]: ./bug-fix-procedure.md [zulip-help]: https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp From 60729a69cd8626f5e092bd2cbd59c75a89f85a03 Mon Sep 17 00:00:00 2001 From: Santiago Pastorino Date: Thu, 18 Mar 2021 20:59:43 -0300 Subject: [PATCH 11/13] Update src/compiler-team.md Co-authored-by: Yuki Okushi --- src/compiler-team.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler-team.md b/src/compiler-team.md index afaefe42f..7b8e1edb5 100644 --- a/src/compiler-team.md +++ b/src/compiler-team.md @@ -53,7 +53,7 @@ They are held on [Zulip][zulip-meetings]. It works roughly as follows: - **Check S-waiting-on-team and I-nominated issues:** These are issues where feedback from the team is desired. - **Look over the performance triage report:** We check for PRs that made the - performance worse and try to decide if it's worth reverting the performance regression or if + performance worse and try to decide if it's worth reverting the performance regression or if the regression can be addressed in a future PR. The meeting currently takes place on Thursdays at 10am Boston time From a3bf02855fa5239167d79ef93b5341b32855896a Mon Sep 17 00:00:00 2001 From: Santiago Pastorino Date: Thu, 18 Mar 2021 20:59:49 -0300 Subject: [PATCH 12/13] Update src/compiler-team.md Co-authored-by: Yuki Okushi --- src/compiler-team.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler-team.md b/src/compiler-team.md index 7b8e1edb5..81fa0edbc 100644 --- a/src/compiler-team.md +++ b/src/compiler-team.md @@ -54,7 +54,7 @@ They are held on [Zulip][zulip-meetings]. It works roughly as follows: the team is desired. - **Look over the performance triage report:** We check for PRs that made the performance worse and try to decide if it's worth reverting the performance regression or if - the regression can be addressed in a future PR. + the regression can be addressed in a future PR. The meeting currently takes place on Thursdays at 10am Boston time (UTC-4 typically, but daylight savings time sometimes makes things From fe987304a9bbe423fd9a6d86f56a94a7de63bf57 Mon Sep 17 00:00:00 2001 From: Santiago Pastorino Date: Thu, 18 Mar 2021 21:00:23 -0300 Subject: [PATCH 13/13] Update src/compiler-team.md Co-authored-by: Yuki Okushi --- src/compiler-team.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler-team.md b/src/compiler-team.md index 81fa0edbc..8cfcc5bb6 100644 --- a/src/compiler-team.md +++ b/src/compiler-team.md @@ -36,7 +36,7 @@ They are held on [Zulip][zulip-meetings]. It works roughly as follows: - **Announcements, MCPs/FCPs, and WG-check-ins:** We share some announcements with the rest of the team about important things we want - everyone to be aware. We also share the status of MCPs and FCPs and we + everyone to be aware of. We also share the status of MCPs and FCPs and we use the opportunity to have a couple of WGs giving us an update about their work. - **Check for beta and stable nominations:** These are nominations of things to