From 4c823ad0360628991deb324049b44942494bdd92 Mon Sep 17 00:00:00 2001 From: LeSeulArtichaut Date: Tue, 24 Mar 2020 14:52:53 +0100 Subject: [PATCH 1/3] Change ICE-breaker ping to use the aliases Related to rust-lang/rust#69949 --- src/ice-breaker/about.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ice-breaker/about.md b/src/ice-breaker/about.md index e71001e5b..60182a3c2 100644 --- a/src/ice-breaker/about.md +++ b/src/ice-breaker/about.md @@ -58,8 +58,8 @@ To tag an issue as appropriate for an ICE-breaker group, you give team. For example: ```text -@rustbot ping icebreakers-llvm -@rustbot ping icebreakers-cleanup-crew +@rustbot ping llvm +@rustbot ping cleanup ``` **Note though that this should only be done by compiler team members From 12b649d633c2906c0cf6982013de591fd927d8ff Mon Sep 17 00:00:00 2001 From: LeSeulArtichaut Date: Wed, 25 Mar 2020 14:17:52 +0100 Subject: [PATCH 2/3] Note that the invocation now are aliases --- src/ice-breaker/about.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/ice-breaker/about.md b/src/ice-breaker/about.md index 60182a3c2..1e5dc9416 100644 --- a/src/ice-breaker/about.md +++ b/src/ice-breaker/about.md @@ -62,9 +62,14 @@ team. For example: @rustbot ping cleanup ``` +These are aliases that are easier to remember than the full invocation. +They are declared in the [`triagebot.toml`] file and might be subject to +changes. + **Note though that this should only be done by compiler team members or contributors, and is typically done as part of compiler team triage.** [rustbot]: https://github.com/rust-lang/triagebot/ [`ping`]: https://github.com/rust-lang/triagebot/wiki/Pinging +[`triagebot.toml`]: https://github.com/rust-lang/rust/blob/master/triagebot.toml From f9cde56387ae73d12129ef60cedf98a2ba750f2f Mon Sep 17 00:00:00 2001 From: LeSeulArtichaut Date: Sun, 5 Apr 2020 12:38:05 +0200 Subject: [PATCH 3/3] Rework commit message --- src/ice-breaker/about.md | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/ice-breaker/about.md b/src/ice-breaker/about.md index 1e5dc9416..642fbe4a1 100644 --- a/src/ice-breaker/about.md +++ b/src/ice-breaker/about.md @@ -57,14 +57,22 @@ To tag an issue as appropriate for an ICE-breaker group, you give [rustbot] a [`ping`] command with the name of the ICE-breakers team. For example: +```text +@rustbot ping icebreakers-llvm +@rustbot ping icebreakers-cleanup-crew +``` + +To make these commands shorter and easier to remember, there are aliases, +defined in the [`triagebot.toml`] file. For example: + ```text @rustbot ping llvm @rustbot ping cleanup ``` -These are aliases that are easier to remember than the full invocation. -They are declared in the [`triagebot.toml`] file and might be subject to -changes. +Keep in mind that these aliases are meant to make humans' life easier. +They might be subject to change. If you need to ensure that a command +will always be valid, prefer the full invocations over the aliases. **Note though that this should only be done by compiler team members or contributors, and is typically done as part of compiler team