Update annotate-snippets-rs to 0.8.0 #4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@botika - Thanks so much letting us know about the upstream changes, and for this PR applying them to rustfmt! We'll review and get back to you soon |
Merged
|
@botika when and if you get a chance, would you be willing to rebase your changes on the latest and resolve the conflicts? rustfmt was broken on nightly and we needed to go ahead and get a fix out which also required modifications to some of the same code as this PR |
|
@calebcartwright Done |
calebcartwright
approved these changes
May 24, 2020
There was a problem hiding this comment.
LGTM, though I'm not terribly familiar with the lib. Will hold off on merging in case you want to take a look @topecongiro
bradleypmartin
pushed a commit
to bradleypmartin/rustfmt
that referenced
this pull request
May 25, 2020
|
backported in #4762 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made major changes to this library. In the previous version we worked with owned while in the current one with borrowed.
I have adapted it without changing the behavior.