Implement One option for imports_granularity (#4669) (Repeat PR)
#4973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option merges all imports into a single `use` statement as long as they have the same visibility.
#4680 was targeting the experimental 2.0 version of rustfmt which has never been released. We were previously tracking that experimental version on the default branch, but decided to stop doing that to increase focus on the main 1.x version of rustfmt that actually is released and supported, refs #4801 It's not that the merge "didn't work out", it's just that it had yet to be pulled into the 1.x mainline so thank you for this backport! |
|
Ohhh that explains it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow the merge of #4680 didn't work out, and the commit doesn't appear in the history of the current
masterbranch.My guess is that this wasn't intended, and the expectation was that the new
Oneoption would become available, so this PR contains the original commit cherry-picked onto the latestmaster, with no changes.@calebcartwright @magurotuna FYI.