Skip to content

Conversation

@ehuss
Copy link
Contributor

@ehuss ehuss commented Sep 3, 2020

This changes it so that docs are only updated during a stable release. This ensures users don't see unreleased changes, which can be confusing.

@ehuss
Copy link
Contributor Author

ehuss commented Sep 3, 2020

#2477 should be merged before this, so that the published docs will get updated. After this is merged, I can follow up with a PR to revert #2477 (already prepared at https://github.com/ehuss/rustup/tree/add-unreleased-docs).

Or, if you don't want to bother with that dance (and you plan to do a new release soon), feel free to just close #2477.

@rbtcollins
Copy link
Contributor

rbtcollins commented Sep 3, 2020 via email

@ehuss
Copy link
Contributor Author

ehuss commented Sep 3, 2020

Sure! Are you thinking just a different URL, like https://rust-lang.github.io/rustup/master/? And leave the root for stable?

I can probably put something like that together, though it'll take a little time.

@kinnison
Copy link
Contributor

kinnison commented Sep 3, 2020

I'd love it if there were a /devel/ for the current master branch (We may rename the branch, so don't encode master in the URL)

@ehuss
Copy link
Contributor Author

ehuss commented Sep 3, 2020

Sounds good! I'll try to put something together. The initial approach might be a little awkward since the docs don't yet exist on the stable branch.

@rbtcollins
Copy link
Contributor

rbtcollins commented Sep 3, 2020 via email

@kinnison
Copy link
Contributor

kinnison commented Sep 5, 2020

I've merged the revert docs PR, and I'll merge this one after the docs have generated. Then I'm fine waiting until a release before we try for more complexity.

@kinnison
Copy link
Contributor

kinnison commented Sep 5, 2020

OK docs have built so I'm merging this. I look forward to the docs reinstatement PR @ehuss

@kinnison kinnison merged commit c89d1ed into rust-lang:master Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants