-
Notifications
You must be signed in to change notification settings - Fork 993
Deploy docs on stable only. #2478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
#2477 should be merged before this, so that the published docs will get updated. After this is merged, I can follow up with a PR to revert #2477 (already prepared at https://github.com/ehuss/rustup/tree/add-unreleased-docs). Or, if you don't want to bother with that dance (and you plan to do a new release soon), feel free to just close #2477. |
|
I think it would be nice to have a published copy of the master tree
somewhere, like rust docs does of nightly, but stable should definitely be
the default folk encounter
…On Fri, 4 Sep 2020, 05:11 Eric Huss, ***@***.***> wrote:
#2477 <#2477> should be merged
before this, so that the published docs will get updated. After this is
merged, I can follow up with a PR to revert #2477
<#2477> (already prepared at
https://github.com/ehuss/rustup/tree/add-unreleased-docs).< /p>
Or, if you don't want to bother with that dance (and you plan to do a new
release soon), feel free to just close #2477
<#2477>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2478 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADZ7XUGYRYMVEPLQ5RHN33SD7E2LANCNFSM4QVFRUDA>
.
|
|
Sure! Are you thinking just a different URL, like https://rust-lang.github.io/rustup/master/? And leave the root for stable? I can probably put something like that together, though it'll take a little time. |
|
I'd love it if there were a |
|
Sounds good! I'll try to put something together. The initial approach might be a little awkward since the docs don't yet exist on the stable branch. |
|
I'd be OK merging a point update to stable of just doc updates if that
would be helpful.
…On Fri, 4 Sep 2020, 07:01 Eric Huss, ***@***.***> wrote:
Sounds good! I'll try to put something together. The initial approach
might be a little awkward since the docs don't yet exist on the stable
branch.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2478 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADZ7XQY4HULJHJI4G2YQLDSD7RWZANCNFSM4QVFRUDA>
.
|
|
I've merged the revert docs PR, and I'll merge this one after the docs have generated. Then I'm fine waiting until a release before we try for more complexity. |
|
OK docs have built so I'm merging this. I look forward to the docs reinstatement PR @ehuss |
This changes it so that docs are only updated during a stable release. This ensures users don't see unreleased changes, which can be confusing.